New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java benchmark to use parser, fix cpp benchmark new arena to use … #4158

Merged
merged 2 commits into from Jan 11, 2018

Conversation

Projects
None yet
4 participants
@BSBandme
Contributor

BSBandme commented Jan 9, 2018

Fix java benchmark to use parser, fix cpp benchmark new arena to use …

@BSBandme BSBandme requested a review from xfxyjwf Jan 9, 2018

@grpc-jenkins

This comment has been minimized.

Show comment
Hide comment
@grpc-jenkins

grpc-jenkins Jan 9, 2018

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-jenkins commented Jan 9, 2018

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-jenkins

This comment has been minimized.

Show comment
Hide comment
@grpc-jenkins

grpc-jenkins Jan 9, 2018

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-jenkins commented Jan 9, 2018

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@googlebot googlebot added the cla: yes label Jan 9, 2018

@xfxyjwf

xfxyjwf approved these changes Jan 9, 2018

while (state.KeepRunning()) {
Arena arena;
arena.Reset();

This comment has been minimized.

@xfxyjwf

xfxyjwf Jan 9, 2018

Contributor

Does this make any difference in the benchmark result?

@xfxyjwf

xfxyjwf Jan 9, 2018

Contributor

Does this make any difference in the benchmark result?

This comment has been minimized.

@BSBandme

BSBandme Jan 10, 2018

Contributor

Seems a little different for some messages.

@BSBandme

BSBandme Jan 10, 2018

Contributor

Seems a little different for some messages.

@BSBandme BSBandme merged commit 9f80df0 into protocolbuffers:master Jan 11, 2018

30 of 32 checks passed

MacOS JRuby (Allowed Failure) Kokoro build finished
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Linux 32-bit Kokoro build finished
Details
Linux C# Kokoro build finished
Details
Linux C++ Distcheck Kokoro build finished
Details
Linux Golang Kokoro build finished
Details
Linux Java Compatibility Kokoro build finished
Details
Linux Java JDK 7 Kokoro build finished
Details
Linux Java Oracle 7 Kokoro build finished
Details
Linux JavaNano JDK 7 Kokoro build finished
Details
Linux JavaNano Oracle 7 Kokoro build finished
Details
Linux JavaScript Kokoro build finished
Details
Linux PHP Kokoro build finished
Details
Linux Python Kokoro build finished
Details
Linux Python C++ Kokoro build finished
Details
Linux Python Compatibility Kokoro build finished
Details
Linux Ruby Kokoro build finished
Details
MacOS C++ Kokoro build finished
Details
MacOS C++ Distcheck Kokoro build finished
Details
MacOS JavaScript Kokoro build finished
Details
MacOS Obj-C CocoaPods Integration Kokoro build finished
Details
MacOS Obj-C OS X Kokoro build finished
Details
MacOS Obj-C iOS Debug (Allowed Failure) Kokoro build finished
Details
MacOS Obj-C iOS Release (Allowed Failure) Kokoro build finished
Details
MacOS PHP5.6 Kokoro build finished
Details
MacOS PHP7.0 Kokoro build finished
Details
MacOS Python Kokoro build finished
Details
MacOS Python C++ (Allowed Failure) Kokoro build finished
Details
MacOS Ruby 2.1 Kokoro build finished
Details
MacOS Ruby 2.2 (Allowed Failure) Kokoro build finished
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment