New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove js_embed binary. #4709

Merged
merged 2 commits into from Jun 1, 2018

Conversation

Projects
None yet
3 participants
@xfxyjwf
Contributor

xfxyjwf commented Jun 1, 2018

No description provided.

@acozzette

This comment has been minimized.

Contributor

acozzette commented Jun 1, 2018

LGTM

@xfxyjwf xfxyjwf merged commit 143851e into protocolbuffers:master Jun 1, 2018

29 checks passed

Bazel Kokoro build successful
Details
Linux 32-bit Kokoro build successful
Details
Linux C# Kokoro build successful
Details
Linux C++ Distcheck Kokoro build successful
Details
Linux Golang Kokoro build successful
Details
Linux Java Compatibility Kokoro build successful
Details
Linux Java JDK 7 Kokoro build successful
Details
Linux Java Oracle 7 Kokoro build successful
Details
Linux JavaScript Kokoro build successful
Details
Linux PHP Kokoro build successful
Details
Linux Python Kokoro build successful
Details
Linux Python C++ Kokoro build successful
Details
Linux Python Compatibility Kokoro build successful
Details
Linux Ruby Kokoro build successful
Details
MacOS C++ Kokoro build successful
Details
MacOS C++ Distcheck Kokoro build successful
Details
MacOS JavaScript Kokoro build successful
Details
MacOS Obj-C CocoaPods Integration Kokoro build successful
Details
MacOS Obj-C OS X Kokoro build successful
Details
MacOS Obj-C iOS Debug (Allowed Failure) Kokoro build successful
Details
MacOS Obj-C iOS Release (Allowed Failure) Kokoro build successful
Details
MacOS PHP5.6 Kokoro build successful
Details
MacOS PHP7.0 Kokoro build successful
Details
MacOS Python Kokoro build successful
Details
MacOS Python C++ (Allowed Failure) Kokoro build successful
Details
MacOS Ruby 2.1 Kokoro build successful
Details
MacOS Ruby 2.2 (Allowed Failure) Kokoro build successful
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@xfxyjwf xfxyjwf added the c++ label Jun 22, 2018

xfxyjwf added a commit to xfxyjwf/protobuf that referenced this pull request Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment