New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source dependency of test suite implementation to main function #5069

Merged
merged 2 commits into from Sep 6, 2018

Conversation

Projects
None yet
5 participants
@TeBoring
Contributor

TeBoring commented Aug 22, 2018

This change adds a source dependency of the test suite implementaion
class in the main function. For generality reason, the main function is
moved to the file of the test suite implemetation. New test suite
implementation will need to implement the main function.
In order to make it easy for test suite implementation to implement the
main function, this change also refactor out the common code out of the
main function.

@xfxyjwf

This comment has been minimized.

Show comment
Hide comment
@xfxyjwf

xfxyjwf Aug 23, 2018

Contributor

Can you do just enough in this PR to make the tests work again and do any follow-up refactoring in a separate PR? Ideally this PR should only contain changes to Makefile.am.

Contributor

xfxyjwf commented Aug 23, 2018

Can you do just enough in this PR to make the tests work again and do any follow-up refactoring in a separate PR? Ideally this PR should only contain changes to Makefile.am.

@TeBoring

This comment has been minimized.

Show comment
Hide comment
@TeBoring

TeBoring Aug 23, 2018

Contributor

Done in #5073

Contributor

TeBoring commented Aug 23, 2018

Done in #5073

@xfxyjwf xfxyjwf assigned haberman and unassigned xfxyjwf Aug 24, 2018

@xfxyjwf

This comment has been minimized.

Show comment
Hide comment
@xfxyjwf

xfxyjwf Aug 24, 2018

Contributor

Bo, can you update the description of this PR accordingly?

Contributor

xfxyjwf commented Aug 24, 2018

Bo, can you update the description of this PR accordingly?

@TeBoring TeBoring changed the title from Fix conformance running nothing issue to Add source dependency of test suite implementation to main function Aug 24, 2018

@TeBoring

This comment has been minimized.

Show comment
Hide comment
@TeBoring

TeBoring Aug 24, 2018

Contributor

Done

Contributor

TeBoring commented Aug 24, 2018

Done

Fix conformance running nothing issue
This change adds a source dependency of the test suite implementaion
class in the main function. For generality reason, the main function is
moved to the file of the test suite implemetation.  New test suite
implementation will need to implement the main function.
In order to make it easy for test suite implementation to implement the
main function, this change also refactor out the common code out of the
main function.
@haberman

I think this is better than the dynamic registration approach.

Show outdated Hide outdated conformance/conformance_test.h

@TeBoring TeBoring merged commit 5aeee3d into protocolbuffers:master Sep 6, 2018

29 checks passed

Bazel Kokoro build successful
Details
Linux 32-bit Kokoro build successful
Details
Linux C# Kokoro build successful
Details
Linux C++ Distcheck Kokoro build successful
Details
Linux Golang Kokoro build successful
Details
Linux Java Compatibility Kokoro build successful
Details
Linux Java JDK 7 Kokoro build successful
Details
Linux Java Oracle 7 Kokoro build successful
Details
Linux JavaScript Kokoro build successful
Details
Linux PHP Kokoro build successful
Details
Linux Python Kokoro build successful
Details
Linux Python C++ Kokoro build successful
Details
Linux Python Compatibility Kokoro build successful
Details
Linux Ruby Kokoro build successful
Details
MacOS C++ Kokoro build successful
Details
MacOS C++ Distcheck Kokoro build successful
Details
MacOS JavaScript Kokoro build successful
Details
MacOS Obj-C CocoaPods Integration Kokoro build successful
Details
MacOS Obj-C OS X Kokoro build successful
Details
MacOS Obj-C iOS Debug (Allowed Failure) Kokoro build successful
Details
MacOS Obj-C iOS Release (Allowed Failure) Kokoro build successful
Details
MacOS PHP5.6 Kokoro build successful
Details
MacOS PHP7.0 Kokoro build successful
Details
MacOS Python Kokoro build successful
Details
MacOS Python C++ (Allowed Failure) Kokoro build successful
Details
MacOS Ruby 2.1 Kokoro build successful
Details
MacOS Ruby 2.2 (Allowed Failure) Kokoro build successful
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment