New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Guava 20 #5122

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
4 participants
@elharo
Contributor

elharo commented Sep 7, 2018

fix #5116

@googlebot googlebot added the cla: yes label Sep 7, 2018

@xfxyjwf

This comment has been minimized.

Show comment
Hide comment
@xfxyjwf

xfxyjwf Sep 7, 2018

Contributor

@ejona86 @carl-mastrangelo Can you help confirm if this upgrade is OK for grpc?

Contributor

xfxyjwf commented Sep 7, 2018

@ejona86 @carl-mastrangelo Can you help confirm if this upgrade is OK for grpc?

@xfxyjwf xfxyjwf self-assigned this Sep 7, 2018

@ejona86

This comment has been minimized.

Show comment
Hide comment
@ejona86

ejona86 Sep 8, 2018

Contributor

Yes, it is fine. grpc-java bumped to Guava 20 at end of March. We've not heard of any compatibility problems this time around.

Contributor

ejona86 commented Sep 8, 2018

Yes, it is fine. grpc-java bumped to Guava 20 at end of March. We've not heard of any compatibility problems this time around.

@ejona86

This comment has been minimized.

Show comment
Hide comment
@ejona86

ejona86 Sep 8, 2018

Contributor

Note also, there will be a release of gRPC on Monday. It will bump our minimum JDK version to 7. If there don't prove to be problems, then we will be able to update to even newer versions of Guava.

Contributor

ejona86 commented Sep 8, 2018

Note also, there will be a release of gRPC on Monday. It will bump our minimum JDK version to 7. If there don't prove to be problems, then we will be able to update to even newer versions of Guava.

@xfxyjwf xfxyjwf merged commit 3bf0245 into protocolbuffers:master Sep 10, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@elharo elharo deleted the elharo:guava20 branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment