Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODO from FieldDescriptorProto.default_value #5800

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@dsnet
Copy link
Contributor

dsnet commented Mar 1, 2019

While the suggested change in behavior would have been nice,
it has gone un-addressed for 11 years. At this point in time,
switching the encoding to base64 is almost certainly not going
to happen without breaking many users who already had to implement
their own C string parser.

Rather than keeping the TODO, just delete it since it does appear
in the documentation of the generated proto for most languages.

Remove TODO from FieldDescriptorProto.default_value
While the suggested change in behavior would have been nice,
it has gone un-addressed for 11 years. At this point in time,
switching the encoding to base64 is almost certainly not going
to happen without breaking many users who already had to implement
their own C string parser.

Rather than keeping the TODO, just delete it since it does appear
in the documentation of the generated proto for most languages.

@googlebot googlebot added the cla: yes label Mar 1, 2019

@TeBoring TeBoring added the kokoro:run label Mar 4, 2019

@kokoro-team kokoro-team removed the kokoro:run label Mar 4, 2019

@TeBoring TeBoring requested a review from haon4 Mar 4, 2019

@haon4

This comment has been minimized.

Copy link
Contributor

haon4 commented Mar 4, 2019

Kokoro tests are failing. I think you would have to update the golden generated files too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.