Add binary conformance tests for map fields #6560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 32-bit platform, int64 should be string. However, map iterator returns string key as integer.
haberman
requested changes
Aug 29, 2019
Conflicts: php/src/Google/Protobuf/Internal/MapEntry.php
TeBoring
added a commit
to TeBoring/protobuf
that referenced
this pull request
Aug 29, 2019
* When length is zero, substr returns null instead of emptry string, which breaks the invariable for message. * Tested in protocolbuffers#6560
TeBoring
added a commit
that referenced
this pull request
Aug 30, 2019
* When length is zero, substr returns null instead of emptry string, which breaks the invariable for message. * Tested in #6560
haberman
approved these changes
Sep 3, 2019
This was referenced Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.