Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a proto_lang_toolchain for javalite #6882

Merged
merged 3 commits into from Nov 27, 2019

Conversation

@rafi-kamal
Copy link
Contributor

rafi-kamal commented Nov 14, 2019

So that javalite can be used from Bazel. Related discussion: #6867

@rafi-kamal

This comment has been minimized.

Copy link
Contributor Author

rafi-kamal commented Nov 14, 2019

@ejona86 do you know how can I test it? Is there a java_lite_proto_library defined somewhere that can depend on this rule?

@ejona86

This comment has been minimized.

Copy link
Contributor

ejona86 commented Nov 16, 2019

It looks like your examples include a java_lite_proto_library :)

protobuf/examples/BUILD

Lines 73 to 76 in 4e93585

java_lite_proto_library(
name = "addressbook_java_lite_proto",
deps = [":addressbook_proto"],
)

(And I only know this because of the build failure you mentioned in #6898)

That means you should also update it's workspace to use a local_repository (just like com_google_protobuf) instead of the http_archive:

http_archive(
name = "com_google_protobuf_javalite",
strip_prefix = "protobuf-javalite",
urls = ["https://github.com/protocolbuffers/protobuf/archive/javalite.zip"],
)

Copy link
Contributor

ejona86 left a comment

I fixed a bug and updated the examples, but now it is running for me. You can test by cd examples/; bazel build :addressbook_java_lite_proto

@rafi-kamal

This comment has been minimized.

Copy link
Contributor Author

rafi-kamal commented Nov 27, 2019

Thank you very much :)

@rafi-kamal rafi-kamal merged commit e6c5a3b into protocolbuffers:master Nov 27, 2019
43 of 56 checks passed
43 of 56 checks passed
MacOS Ruby 2.3 Kokoro build failed
Details
Dist artifact installation Kokoro build started.
Details
Linux C++ Distcheck Kokoro build started.
Details
Linux C++ TC Malloc Kokoro build started.
Details
Linux Java JDK 7 Kokoro build started.
Details
Linux Java Oracle 7 Kokoro build started.
Details
Linux Python Release Kokoro build started.
Details
MacOS C++ Kokoro build started.
Details
MacOS C++ Distcheck Kokoro build started.
Details
MacOS Python Release Kokoro build started.
Details
MacOS Ruby 2.5 Kokoro build started.
Details
MacOS Ruby Release Kokoro build started.
Details
Windows Python Release Kokoro build started.
Details
Bazel Kokoro build successful
Details
Linux 32-bit Kokoro build successful
Details
Linux C# Kokoro build successful
Details
Linux Golang Kokoro build successful
Details
Linux Java Compatibility Kokoro build successful
Details
Linux Java Linkage Monitor Kokoro build successful
Details
Linux JavaScript Kokoro build successful
Details
Linux PHP Kokoro build successful
Details
Linux Python Kokoro build successful
Details
Linux Python 2.7 Kokoro build successful
Details
Linux Python 2.7 C++ Kokoro build successful
Details
Linux Python 3.3 Kokoro build successful
Details
Linux Python 3.3 C++ Kokoro build successful
Details
Linux Python 3.4 Kokoro build successful
Details
Linux Python 3.4 C++ Kokoro build successful
Details
Linux Python 3.5 Kokoro build successful
Details
Linux Python 3.5 C++ Kokoro build successful
Details
Linux Python 3.6 Kokoro build successful
Details
Linux Python 3.6 C++ Kokoro build successful
Details
Linux Python 3.7 Kokoro build successful
Details
Linux Python 3.7 C++ Kokoro build successful
Details
Linux Python C++ Kokoro build successful
Details
Linux Python Compatibility Kokoro build successful
Details
Linux Ruby 2.3 Kokoro build successful
Details
Linux Ruby 2.4 Kokoro build successful
Details
Linux Ruby 2.5 Kokoro build successful
Details
Linux Ruby 2.6 Kokoro build successful
Details
Linux Ruby Release Kokoro build successful
Details
MacOS JavaScript Kokoro build successful
Details
MacOS Obj-C CocoaPods Integration Kokoro build successful
Details
MacOS Obj-C OS X Kokoro build successful
Details
MacOS Obj-C iOS Debug Kokoro build successful
Details
MacOS Obj-C iOS Release Kokoro build successful
Details
MacOS PHP5.6 Kokoro build successful
Details
MacOS PHP7.0 Kokoro build successful
Details
MacOS Python Kokoro build successful
Details
MacOS Python C++ Kokoro build successful
Details
MacOS Ruby 2.4 Kokoro build successful
Details
MacOS Ruby 2.6 Kokoro build successful
Details
Mergeable Mergeable Run has been Completed!
Details
Windows C# Kokoro build successful
Details
Windows Csharp Release Kokoro build successful
Details
cla/google All necessary CLAs are signed
ejona86 added a commit to ejona86/protobuf that referenced this pull request Dec 3, 2019
* Add a proto_lang_toolchain for javalite

* fix toolchain. Swap javalite example to master repo
ejona86 added a commit to ejona86/protobuf that referenced this pull request Dec 3, 2019
* Add a proto_lang_toolchain for javalite

* fix toolchain. Swap javalite example to master repo
rafi-kamal added a commit that referenced this pull request Dec 3, 2019
* Add a proto_lang_toolchain for javalite

* fix toolchain. Swap javalite example to master repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.