Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf version #6898

Merged
merged 1 commit into from Nov 16, 2019

Conversation

@rafi-kamal
Copy link
Contributor

rafi-kamal commented Nov 15, 2019

No description provided.

@rafi-kamal

This comment has been minimized.

Copy link
Contributor Author

rafi-kamal commented Nov 15, 2019

@TeBoring some the PHP files have changed. Do you know why?

@TeBoring

This comment has been minimized.

Copy link
Contributor

TeBoring commented Nov 15, 2019

@rafi-kamal

This comment has been minimized.

Copy link
Contributor Author

rafi-kamal commented Nov 16, 2019

The Bazel tests are failing with the following error:

ERROR: /tmpfs/src/github/protobuf/examples/BUILD:73:1: //:addressbook_java_lite_proto depends on @com_google_protobuf_javalite//:javalite_toolchain in repository @com_google_protobuf_javalite which failed to fetch. no such package '@com_google_protobuf_javalite//': java.io.IOException: Error downloading [https://github.com/protocolbuffers/protobuf/archive/javalite.zip] to /tmpfs/tmp/bazel/external/com_google_protobuf_javalite/javalite.zip: GET returned 404 Not Found

@ejona86 could this be related to the javalite stuffs you have been working on?

@rafi-kamal

This comment has been minimized.

Copy link
Contributor Author

rafi-kamal commented Nov 16, 2019

Actually, the failure seems to be unrelated to Eric's change (grpc/grpc-java#6424). That change was submitting yesterday, our tests started failing from this noon (https://g3c.corp.google.com/results/invocations;query=protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fbazel%2Fpresubmit).

@rafi-kamal

This comment has been minimized.

Copy link
Contributor Author

rafi-kamal commented Nov 16, 2019

Looks like our javalite branch got vanished somehow. I've restored the branch, hopefully that will fix the error.

@rafi-kamal rafi-kamal merged commit 3cc55d6 into protocolbuffers:master Nov 16, 2019
56 checks passed
56 checks passed
Bazel Kokoro build successful
Details
Dist artifact installation Kokoro build successful
Details
Linux 32-bit Kokoro build successful
Details
Linux C# Kokoro build successful
Details
Linux C++ Distcheck Kokoro build successful
Details
Linux C++ TC Malloc Kokoro build successful
Details
Linux Golang Kokoro build successful
Details
Linux Java Compatibility Kokoro build successful
Details
Linux Java JDK 7 Kokoro build successful
Details
Linux Java Linkage Monitor Kokoro build successful
Details
Linux Java Oracle 7 Kokoro build successful
Details
Linux JavaScript Kokoro build successful
Details
Linux PHP Kokoro build successful
Details
Linux Python Kokoro build successful
Details
Linux Python 2.7 Kokoro build successful
Details
Linux Python 2.7 C++ Kokoro build successful
Details
Linux Python 3.3 Kokoro build successful
Details
Linux Python 3.3 C++ Kokoro build successful
Details
Linux Python 3.4 Kokoro build successful
Details
Linux Python 3.4 C++ Kokoro build successful
Details
Linux Python 3.5 Kokoro build successful
Details
Linux Python 3.5 C++ Kokoro build successful
Details
Linux Python 3.6 Kokoro build successful
Details
Linux Python 3.6 C++ Kokoro build successful
Details
Linux Python 3.7 Kokoro build successful
Details
Linux Python 3.7 C++ Kokoro build successful
Details
Linux Python C++ Kokoro build successful
Details
Linux Python Compatibility Kokoro build successful
Details
Linux Python Release Kokoro build successful
Details
Linux Ruby 2.3 Kokoro build successful
Details
Linux Ruby 2.4 Kokoro build successful
Details
Linux Ruby 2.5 Kokoro build successful
Details
Linux Ruby 2.6 Kokoro build successful
Details
Linux Ruby Release Kokoro build successful
Details
MacOS C++ Kokoro build successful
Details
MacOS C++ Distcheck Kokoro build successful
Details
MacOS JavaScript Kokoro build successful
Details
MacOS Obj-C CocoaPods Integration Kokoro build successful
Details
MacOS Obj-C OS X Kokoro build successful
Details
MacOS Obj-C iOS Debug Kokoro build successful
Details
MacOS Obj-C iOS Release Kokoro build successful
Details
MacOS PHP5.6 Kokoro build successful
Details
MacOS PHP7.0 Kokoro build successful
Details
MacOS Python Kokoro build successful
Details
MacOS Python C++ Kokoro build successful
Details
MacOS Python Release Kokoro build successful
Details
MacOS Ruby 2.3 Kokoro build successful
Details
MacOS Ruby 2.4 Kokoro build successful
Details
MacOS Ruby 2.5 Kokoro build successful
Details
MacOS Ruby 2.6 Kokoro build successful
Details
MacOS Ruby Release Kokoro build successful
Details
Mergeable Mergeable Run has been Completed!
Details
Windows C# Kokoro build successful
Details
Windows Csharp Release Kokoro build successful
Details
Windows Python Release Kokoro build successful
Details
cla/google All necessary CLAs are signed
rafi-kamal added a commit that referenced this pull request Nov 19, 2019
@rafi-kamal rafi-kamal deleted the rafi-kamal:3.11.x-201911151144 branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.