Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #7050

Merged
merged 3 commits into from Jan 8, 2020
Merged

Fix typos #7050

merged 3 commits into from Jan 8, 2020

Conversation

@bwignall
Copy link
Contributor

bwignall commented Dec 26, 2019

Should be non-semantic.

Uses https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines to find likely typos, with https://github.com/bwignall/typochecker to help automate the checking.

@googlebot googlebot added the cla: yes label Dec 26, 2019
outputStream.Write(bytes, 0, bytes.Length);
}
}
#region Copyright notice and license

This comment has been minimized.

Copy link
@rafi-kamal

rafi-kamal Jan 7, 2020

Contributor

Can you please revert the changes here?

#endregion
}
}
#region Copyright notice and license

This comment has been minimized.

Copy link
@rafi-kamal

rafi-kamal Jan 7, 2020

Contributor

Also here

Copy link
Contributor

rafi-kamal left a comment

Thanks!

@bwignall

This comment has been minimized.

Copy link
Contributor Author

bwignall commented Jan 7, 2020

@rafi-kamal , thank you for your review. I have put in the changes you requested:

I have pushed git checkout 6263268b8c1b78a8a9b65acd6f5dd5c04dd9b0e1 -- csharp/src/Google.Protobuf/ByteString.cs csharp/src/Google.Protobuf/CodedInputStream.cs, where I used the most recent hash from before my changes in my fork.

@rafi-kamal

This comment has been minimized.

Copy link
Contributor

rafi-kamal commented Jan 7, 2020

Thanks! Can you please also rebase your changes on top of master and resolve the merge conflict in protoc-artifacts/README.md?

bwignall added 3 commits Dec 26, 2019
@bwignall

This comment has been minimized.

Copy link
Contributor Author

bwignall commented Jan 8, 2020

@rafi-kamal : this should be done now.

@rafi-kamal rafi-kamal merged commit a104dff into protocolbuffers:master Jan 8, 2020
53 of 58 checks passed
53 of 58 checks passed
Linux Python 3.8 Kokoro build failed
Details
Linux Python 3.8 C++ Kokoro build failed
Details
Linux Ruby Release Kokoro build failed
Details
MacOS Python Release Kokoro build failed
Details
MacOS Ruby 2.3 Kokoro build failed
Details
Bazel Kokoro build successful
Details
Dist artifact installation Kokoro build successful
Details
Linux 32-bit Kokoro build successful
Details
Linux C# Kokoro build successful
Details
Linux C++ Distcheck Kokoro build successful
Details
Linux C++ TC Malloc Kokoro build successful
Details
Linux Golang Kokoro build successful
Details
Linux Java Compatibility Kokoro build successful
Details
Linux Java JDK 7 Kokoro build successful
Details
Linux Java Linkage Monitor Kokoro build successful
Details
Linux Java Oracle 7 Kokoro build successful
Details
Linux JavaScript Kokoro build successful
Details
Linux PHP Kokoro build successful
Details
Linux Python Kokoro build successful
Details
Linux Python 2.7 Kokoro build successful
Details
Linux Python 2.7 C++ Kokoro build successful
Details
Linux Python 3.3 Kokoro build successful
Details
Linux Python 3.3 C++ Kokoro build successful
Details
Linux Python 3.4 Kokoro build successful
Details
Linux Python 3.4 C++ Kokoro build successful
Details
Linux Python 3.5 Kokoro build successful
Details
Linux Python 3.5 C++ Kokoro build successful
Details
Linux Python 3.6 Kokoro build successful
Details
Linux Python 3.6 C++ Kokoro build successful
Details
Linux Python 3.7 Kokoro build successful
Details
Linux Python 3.7 C++ Kokoro build successful
Details
Linux Python C++ Kokoro build successful
Details
Linux Python Compatibility Kokoro build successful
Details
Linux Python Release Kokoro build successful
Details
Linux Ruby 2.3 Kokoro build successful
Details
Linux Ruby 2.4 Kokoro build successful
Details
Linux Ruby 2.5 Kokoro build successful
Details
Linux Ruby 2.6 Kokoro build successful
Details
MacOS C++ Kokoro build successful
Details
MacOS C++ Distcheck Kokoro build successful
Details
MacOS JavaScript Kokoro build successful
Details
MacOS Obj-C CocoaPods Integration Kokoro build successful
Details
MacOS Obj-C OS X Kokoro build successful
Details
MacOS Obj-C iOS Debug Kokoro build successful
Details
MacOS Obj-C iOS Release Kokoro build successful
Details
MacOS PHP5.6 Kokoro build successful
Details
MacOS PHP7.0 Kokoro build successful
Details
MacOS Python Kokoro build successful
Details
MacOS Python C++ Kokoro build successful
Details
MacOS Ruby 2.4 Kokoro build successful
Details
MacOS Ruby 2.5 Kokoro build successful
Details
MacOS Ruby 2.6 Kokoro build successful
Details
MacOS Ruby Release Kokoro build successful
Details
Mergeable Mergeable Run has been Completed!
Details
Windows C# Kokoro build successful
Details
Windows Csharp Release Kokoro build successful
Details
Windows Python Release Kokoro build successful
Details
cla/google All necessary CLAs are signed
@bwignall bwignall deleted the bwignall:typo branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.