Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix std::is_pod deprecated in C++20 #7180

Merged
merged 2 commits into from Nov 24, 2020

Conversation

stac47
Copy link
Contributor

@stac47 stac47 commented Feb 6, 2020

I followed the deprecation message to fix the compilation for C++ 20. It works like a charm with gcc 10 (almost HEAD).

@googlebot
Copy link

@googlebot googlebot commented Feb 6, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@stac47 stac47 force-pushed the fix_deprecated_is_pod branch from e8eccf7 to 3387650 Compare Feb 6, 2020
@googlebot
Copy link

@googlebot googlebot commented Feb 6, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Feb 6, 2020
@egorpugin
Copy link
Contributor

@egorpugin egorpugin commented Nov 22, 2020

+1

@acozzette acozzette added c++ release notes: yes kokoro:force-run labels Nov 24, 2020
@acozzette acozzette merged commit 977dde9 into protocolbuffers:master Nov 24, 2020
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ cla: yes release notes: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants