Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Move Java runtime/toolchains into //java #7190

Merged
merged 2 commits into from Feb 13, 2020

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Feb 8, 2020

This change moves java_library targets from the top-level BUILD file
into //java/{core,lite,util} and declares alias targets to point to
their new locations (hence, this is not a breaking change).

This will allow users that don't use Java to stop depending on
@rules_java (e.g. as requested in
bazelbuild/rules_scala#989 (comment)).

Note that there is no intention to deprecate + remove the top-level
targets in the foreseeable future.

@Yannic
Copy link
Contributor Author

@Yannic Yannic commented Feb 8, 2020

/cc @ittaiz

@ittaiz
Copy link
Contributor

@ittaiz ittaiz commented Feb 8, 2020

Nice! Do you think the same can be done for python?

@Yannic Yannic force-pushed the bazel_java branch 3 times, most recently from 112ee78 to 64c3d43 Compare Feb 8, 2020
@Yannic
Copy link
Contributor Author

@Yannic Yannic commented Feb 8, 2020

I haven't looked into doing the same for other languages yet. Will do when this lands.

@ittaiz
Copy link
Contributor

@ittaiz ittaiz commented Feb 9, 2020

Thanks!

@Yannic
Copy link
Contributor Author

@Yannic Yannic commented Feb 11, 2020

@rafi-kamal Thanks! Looks like there were infra issues yesterday. Maybe re-run the tests?

@rafi-kamal rafi-kamal added kokoro:run release notes: yes labels Feb 11, 2020
This change moves `java_library` targets from the top-level BUILD file
into `//java/{core,lite,util}` and declares `alias` targets to point to
their new locations (hence, this is not a breaking change).

This will allow users that don't use Java to stop depending on
`@rules_java` (e.g. as requested in
bazelbuild/rules_scala#989 (comment)).

Note that there is no intention to deprecate + remove the top-level
targets in the foreseeable future.
@rafi-kamal
Copy link
Contributor

@rafi-kamal rafi-kamal commented Feb 12, 2020

@Yannic can you please add the build files to java_EXTRA_DIST in https://github.com/protocolbuffers/protobuf/blob/master/Makefile.am?

The PHP and Python failures are unrelated.

@Yannic
Copy link
Contributor Author

@Yannic Yannic commented Feb 13, 2020

@rafi-kamal Thanks, done!

@rafi-kamal rafi-kamal merged commit f0cb9cd into protocolbuffers:master Feb 13, 2020
54 of 56 checks passed
Yannic added a commit to Yannic/continuous-integration that referenced this issue Feb 21, 2020
Java-specific targets were moved into //java in protocolbuffers/protobuf#7190
@Yannic Yannic deleted the bazel_java branch Feb 21, 2020
fweikert pushed a commit to bazelbuild/continuous-integration that referenced this issue Feb 21, 2020
Java-specific targets were moved into //java in protocolbuffers/protobuf#7190
Yannic added a commit to Yannic/protobuf that referenced this issue Jul 8, 2020
Removing language-specific targets from the top-level BUILD file
will allow users to keep their workspaces smaller and easier to
maintain by not depending on language rules they don't need.

Similar work was done for Java in protocolbuffers#7190.
acozzette pushed a commit that referenced this issue Jul 20, 2020
Removing language-specific targets from the top-level BUILD file
will allow users to keep their workspaces smaller and easier to
maintain by not depending on language rules they don't need.

Similar work was done for Java in #7190.
vesavlad pushed a commit to vesavlad/protobuf that referenced this issue Sep 22, 2020
Removing language-specific targets from the top-level BUILD file
will allow users to keep their workspaces smaller and easier to
maintain by not depending on language rules they don't need.

Similar work was done for Java in protocolbuffers#7190.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel cla: yes java release notes: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants