Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for JSON serialization of 0/empty-valued wrapper types #7198

Merged
merged 2 commits into from Feb 11, 2020

Conversation

haberman
Copy link
Member

@haberman haberman commented Feb 11, 2020

Fixes: #6903
Fixes: #6754

@haberman haberman added ruby release notes: yes kokoro:run labels Feb 11, 2020
@haberman haberman merged commit f2c5ee5 into protocolbuffers:master Feb 11, 2020
54 of 56 checks passed
rafi-kamal pushed a commit that referenced this issue Feb 12, 2020
* Fixed Ruby JSON serialization of 0/empty wrapper fields.

* Removed newly-passing conformance tests from the failure list.
rafi-kamal pushed a commit that referenced this issue Feb 12, 2020
* Fixed Ruby JSON serialization of 0/empty wrapper fields.

* Removed newly-passing conformance tests from the failure list.
rafi-kamal added a commit that referenced this issue Feb 12, 2020
…7204)

* Fixed Ruby JSON serialization of 0/empty wrapper fields.

* Removed newly-passing conformance tests from the failure list.

Co-authored-by: Joshua Haberman <jhaberman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes release notes: yes ruby
Projects
None yet
4 participants