Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Map.clone to use Map's dup method #7938

Merged
merged 1 commit into from Oct 14, 2021

Conversation

alusco-scratch
Copy link
Contributor

@alusco-scratch alusco-scratch commented Oct 2, 2020

Message and Repeated field override clone so that it uses the internal implementation of dup but Map is missing this and only implements dup. This can lead to unexpected behavior since two out of three complex types behave correctly.


This change is Reviewable

Message and Repeated field override clone so that it uses the internal implementation of dup but Map is missing this and only implements dup.  This can lead to unexpected behavior since two out of three complex types behave correctly.
@googlebot
Copy link

@googlebot googlebot commented Oct 2, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@alusco-scratch
Copy link
Contributor Author

@alusco-scratch alusco-scratch commented Oct 2, 2020

Signed a CLA

@alusco-scratch
Copy link
Contributor Author

@alusco-scratch alusco-scratch commented Oct 2, 2020

@googlebot I signed it!

@googlebot
Copy link

@googlebot googlebot commented Oct 2, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Oct 2, 2020
@acozzette acozzette requested a review from haberman Oct 2, 2020
@acozzette acozzette added ruby release notes: no kokoro:run labels Oct 2, 2020
@acozzette acozzette added release notes: yes kokoro:force-run and removed release notes: no labels Oct 13, 2021
@deannagarcia
Copy link
Member

@deannagarcia deannagarcia commented Oct 14, 2021

Sorry for the delay and thanks for the contribution, merging now!

@deannagarcia deannagarcia merged commit 5106dea into protocolbuffers:master Oct 14, 2021
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes release notes: yes ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants