Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some -Wunused-parameter warnings #8053

merged 1 commit into from Nov 17, 2020


Copy link

With every release new unused parameters appear in the codebase (the previous one was fixed in #7878).

@acozzette, is there any option to ensure the absence of such parameters via CI / testing?

@google-cla google-cla bot added the cla: yes label Nov 17, 2020
@acozzette acozzette merged commit 0321358 into protocolbuffers:master Nov 17, 2020
Copy link

@georgthegreat Thanks for the fix. We could potentially change this line to CXXFLAGS="-Werror=unused-parameter" ./configure to make this an error, but I tried it just now and it won't build successfully without fixing other cases in protoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants