Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove CMAKE_THREAD_LIBS_INIT from pkgconfig CFLAGS #8154

Merged
merged 1 commit into from Dec 28, 2020
Merged

remove CMAKE_THREAD_LIBS_INIT from pkgconfig CFLAGS #8154

merged 1 commit into from Dec 28, 2020

Conversation

neheb
Copy link
Contributor

@neheb neheb commented Dec 18, 2020

This is a linker flag and does not belong in CFLAGS.

Fixes an issue with ola and protobuf.

Signed-off-by: Rosen Penev rosenp@gmail.com

This is a linker flag and does not belong in CFLAGS.

Fixes an issue with ola and protobuf.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@google-cla google-cla bot added the cla: yes label Dec 18, 2020
@acozzette acozzette added c++ release notes: yes Include this PR description in the next release kokoro:run labels Dec 21, 2020
@acozzette acozzette merged commit cb8ca28 into protocolbuffers:master Dec 28, 2020
54 checks passed
@acozzette
Copy link
Member

acozzette commented Dec 28, 2020

Thanks, @neheb.

@neheb neheb deleted the pkg branch Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ cla: yes release notes: yes Include this PR description in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants