Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for compiler warning issue#8145 #8160

Merged

Conversation

akjain2052
Copy link
Contributor

@akjain2052 akjain2052 commented Dec 22, 2020

Corrected the == check condition.

@google-cla google-cla bot added the cla: yes label Dec 22, 2020
@akjain2052
Copy link
Contributor Author

@akjain2052 akjain2052 commented Dec 22, 2020

This is the fix for this Issue#8145

Issue: Compiler Warning on GOOGLE_CHECK #8145

Language: C++

Reason for warning:
In cpp_message.cc at line#1074 GOOGLE_CHECK(utf8_check = VERIFY);
Expecting a conditional check at line#1074 utf8_check == VERIFY instead of utf8_check = VERIFY

Solution: Added utf8_check == VERIFY instead of utf8_check = VERIFY

@akjain2052
Copy link
Contributor Author

@akjain2052 akjain2052 commented Dec 22, 2020

Please add labels for release notes and language c++ .

@akjain2052
Copy link
Contributor Author

@akjain2052 akjain2052 commented Dec 22, 2020

Please review this PR.

@acozzette acozzette added release notes: yes kokoro:run labels Dec 22, 2020
@akjain2052
Copy link
Contributor Author

@akjain2052 akjain2052 commented Dec 23, 2020

Please add label:c++

Corrected the == check condition.

Signed-off-by: Abhishek Jain <abhishek.jain3@huawei.com>
@akjain2052 akjain2052 force-pushed the fix-issue-8145-compiler-warning branch from 413eb09 to 52a9564 Compare Dec 24, 2020
@acozzette acozzette merged commit 36aff6a into protocolbuffers:master Dec 28, 2020
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ cla: yes release notes: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants