Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more information to "file already loaded" warning. #8276

Merged
merged 1 commit into from Feb 11, 2021

Conversation

haberman
Copy link
Member

@haberman haberman commented Feb 10, 2021

Also changed it to zend_error() so it is more easily suppressed.

Errors will now look like:

PHP Warning: proto descriptor was previously loaded (included in multiple metadata bundles?): google/ads/googleads/v6/errors/feed_item_validation_error.proto in /usr/local/google/home/haberman/code/google-ads-php/metadata/Google/Ads/GoogleAds/V6/Services/GoogleAdsService.php on line 29

Fixes #8124

Also changed it to zend_error() so it is more easily suppressed.
@haberman haberman added php kokoro:run release notes: yes labels Feb 10, 2021
@haberman haberman requested a review from acozzette Feb 10, 2021
@google-cla google-cla bot added the cla: yes label Feb 10, 2021
@haberman haberman merged commit a97c4f4 into protocolbuffers:3.15.x Feb 11, 2021
55 of 58 checks passed
@haberman haberman deleted the php-warning branch Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes php release notes: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants