Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maven-bundle-plugin to fix duplicate class errors #8653

Merged

Conversation

@deannagarcia
Copy link
Contributor

@deannagarcia deannagarcia commented May 24, 2021

The maven-bundle-plugin was causing the protobuf-kotlin jar to also have all source from protobuf-java which led to error #8631. This should fix it by removing the bundle so that protobuf-kotlin will not have conflicting files.

@fowles
fowles approved these changes May 24, 2021
@deannagarcia deannagarcia changed the base branch from master to 3.17.x May 25, 2021
@google-cla google-cla bot added cla: no and removed cla: yes labels May 25, 2021
@deannagarcia deannagarcia force-pushed the deannagarcia:fixDuplicateClassErrors branch from 771fa8b to 021329b May 25, 2021
@google-cla google-cla bot added cla: yes and removed cla: no labels May 25, 2021
@protocolbuffers protocolbuffers deleted a comment from google-cla bot May 25, 2021
@deannagarcia deannagarcia merged commit b87d364 into protocolbuffers:3.17.x May 25, 2021
3 checks passed
3 checks passed
@github-actions
Check for spelling errors
Details
@mergeable
Mergeable Mergeable Run has been Completed!
Details
@google-cla
cla/google All necessary CLAs are signed
@deannagarcia deannagarcia deleted the deannagarcia:fixDuplicateClassErrors branch May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants