Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using std::iterator (deprecated in C++17). #8741

merged 1 commit into from Jun 28, 2021


Copy link

Fixes #7120
Fixes #5416 (maybe?)

Weirdly, the changelog claims that this was already fixed in

2019-04-29 version 3.8.0
  * [c++17] Changed proto2::RepeatedPtrField iterators to no longer derive from the deprecated std::iterator class.

Copy link
Contributor Author

@fowles looks like you're the one to poke about C++ reviews? PTAL :)

@perezd perezd requested a review from dlj-NaN June 22, 2021 16:16
Copy link

perezd commented Jun 22, 2021

They are not available for the moment, so I've assigned @dlj-NaN who can also review this.

@acozzette acozzette merged commit ed8b2e6 into protocolbuffers:master Jun 28, 2021
Copy link

Thanks, @Quuxplusone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Do not inherit from std::iterator vs2017 15.9.3 c++ 17 标准编译不通过
4 participants