Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using std::iterator (deprecated in C++17). #8741

Merged
merged 1 commit into from Jun 28, 2021

Conversation

Quuxplusone
Copy link
Contributor

@Quuxplusone Quuxplusone commented Jun 17, 2021

Fixes #7120
Fixes #5416 (maybe?)

Weirdly, the changelog claims that this was already fixed in

2019-04-29 version 3.8.0
[...]
  * [c++17] Changed proto2::RepeatedPtrField iterators to no longer derive from the deprecated std::iterator class.

@google-cla google-cla bot added the cla: yes label Jun 17, 2021
@acozzette acozzette added release notes: yes Include this PR description in the next release c++ kokoro:run labels Jun 17, 2021
@Quuxplusone
Copy link
Contributor Author

Quuxplusone commented Jun 22, 2021

@fowles looks like you're the one to poke about C++ reviews? PTAL :)

@perezd perezd requested a review from dlj-NaN Jun 22, 2021
@perezd
Copy link
Contributor

perezd commented Jun 22, 2021

They are not available for the moment, so I've assigned @dlj-NaN who can also review this.

@acozzette acozzette merged commit ed8b2e6 into protocolbuffers:master Jun 28, 2021
52 of 54 checks passed
@acozzette
Copy link
Member

acozzette commented Jun 28, 2021

Thanks, @Quuxplusone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ cla: yes release notes: yes Include this PR description in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not inherit from std::iterator vs2017 15.9.3 c++ 17 标准编译不通过
4 participants