Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move field_access_listener from libprotobuf-lite to libprotobuf #8775

Merged
merged 1 commit into from Jun 28, 2021

Conversation

acozzette
Copy link
Member

@acozzette acozzette commented Jun 28, 2021

This should fix #8768. The field access listener code can't build
successfully as part of protobuf-lite because it relies on descriptors.

This should fix protocolbuffers#8768. The field access listener code can't build
successfully as part of protobuf-lite because it relies on descriptors.
@google-cla google-cla bot added the cla: yes label Jun 28, 2021
@acozzette acozzette added release notes: yes Include this PR description in the next release and removed cla: yes labels Jun 28, 2021
@google-cla google-cla bot added the cla: yes label Jun 28, 2021
@acozzette acozzette requested a review from fowles Jun 28, 2021
fowles
fowles approved these changes Jun 28, 2021
@acozzette acozzette merged commit 336ed18 into protocolbuffers:master Jun 28, 2021
53 of 54 checks passed
@acozzette acozzette deleted the fix-cmake-build branch Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ cla: yes release notes: yes Include this PR description in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protobuf lite fails to link when building with shared libs
4 participants