Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated version of SetTotalBytesLimit() #8794

Merged
merged 2 commits into from Jul 9, 2021

Conversation

georgthegreat
Copy link
Contributor

@georgthegreat georgthegreat commented Jul 6, 2021

It has been deprecated for at least 3 years.
Worse backward incompatible things have happened during this period.

I think this method could be safely removed, as the client code fix is trivial.

It has been depcated for at least 3 years.
Worst (backward incompatible) things happened during this period.

I think this method could be safely removed, as the client code fix is trivial.
@google-cla google-cla bot added the cla: yes label Jul 6, 2021
@acozzette acozzette added c++ release notes: yes Include this PR description in the next release kokoro:run labels Jul 7, 2021
@acozzette
Copy link
Member

acozzette commented Jul 8, 2021

It looks like coded_stream_unittest.cc needs to be updated because it still exercises the deprecated function.

@georgthegreat
Copy link
Contributor Author

georgthegreat commented Jul 9, 2021

Thanks, Adam.
This should be fixed now.

@acozzette acozzette merged commit cda7954 into protocolbuffers:master Jul 9, 2021
53 of 54 checks passed
@acozzette
Copy link
Member

acozzette commented Jul 9, 2021

@georgthegreat Thanks for the cleanup!

@georgthegreat georgthegreat deleted the patch-1 branch Jul 10, 2021
@MohamadHalwani
Copy link

MohamadHalwani commented Jul 26, 2021

error: no matching function for call to ‘google::protobuf::io::CodedInputStream::SetTotalBytesLimit(const int&, const int&)’
any idea ?

@georgthegreat
Copy link
Contributor Author

georgthegreat commented Jul 26, 2021

You should use single parameter version instead.

madisongh pushed a commit to OE4T/meta-tegra that referenced this pull request Sep 27, 2021
This is needed because of upgrade version of protobuf from 3.17.x to 3.18.x
in meta-openembedded

https://git.openembedded.org/meta-openembedded/commit/?id=d7d9597348534b9d93dd7ed8ef49fa2b5c33969d

For more details, deprecated version of SetTotalBytesLimit API was removed
in PR #8794 (protocolbuffers/protobuf#8794)

Signed-off-by: Ilies CHERGUI <ilies.chergui@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ cla: yes release notes: yes Include this PR description in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants