Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby_generator.cc to allow proto2 imports in proto3 #9003

Merged
merged 6 commits into from Sep 22, 2021

Conversation

zhangskz
Copy link
Member

@zhangskz zhangskz commented Sep 20, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Sep 20, 2021
@zhangskz zhangskz added protoc release notes: yes Include this PR description in the next release ruby kokoro:run labels Sep 20, 2021
@zhangskz zhangskz requested a review from haberman Sep 20, 2021
@zhangskz zhangskz changed the title Update ruby_generator.cc to allow proto2 imports in proto3, with updated unit tests Update ruby_generator.cc to allow proto2 imports in proto3 Sep 20, 2021
@haberman
Copy link
Member

haberman commented Sep 21, 2021

This looks great. Could you also add a test in one of these protos, to ensure that the generated code can be successfully loaded into a Ruby process and used?

https://github.com/protocolbuffers/protobuf/tree/master/ruby/tests

I think this is a good candidate; you could make this file import one of the proto2 protos from this directory: https://github.com/protocolbuffers/protobuf/blob/master/ruby/tests/basic_test.proto

Then add a test in https://github.com/protocolbuffers/protobuf/blob/master/ruby/tests/basic.rb

@zhangskz zhangskz merged commit 740c4b0 into protocolbuffers:3.18.x Sep 22, 2021
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes protoc release notes: yes Include this PR description in the next release ruby
Projects
None yet
3 participants