Skip to content

Export cmake config package files and add bootstrap buildings. #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

owent
Copy link

@owent owent commented Jun 12, 2023

Fixes protocolbuffers/protobuf#13732
Fixes protocolbuffers/protobuf#13731

  • Export cmake config package files.
  • Add bootstrap building support for cmake, and add stage0,stage1,stage2 targets just like in bazel.
  • Add UPB_ENABLE_CODEGEN options to decide whether to enable boostrap building and use upb,upbdefs and lupb in it to generate *.upb.*.

+ Add bootstrap building support for cmake, and add stage0,stage1,stage2 targets just like in bazel.
+ Add `UPB_ENABLE_CODEGEN` options to decide whether to enable boostrap building and use upb,upbdefs and lupb in it to generate `*.upb.*`.

Signed-off-by: owent <admin@owent.net>
@ericsalo ericsalo requested a review from haberman August 29, 2023 15:02
@acozzette
Copy link
Member

@owent Sorry for the bad news, but I don't think we will be able to accept this change. We just moved upb into the protobuf repo here and we're also planning on doing a complete rewrite of upb's CMake config, so unfortunately we can't accept such a big change to the CMake config.

@acozzette acozzette closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants