virtual identity plugin #498
Conversation
|
|
||
| let mainWindow = getMail3Pane(); | ||
|
|
||
| let virtualIdentityHook = { |
There was a problem hiding this comment.
This is not going to work if the user right-clicks on a folder, hits "open" (opens a new window), and closes the first window, because then the mainWindow will be an invalid reference. What you need to do is call getMail3Pane() everywhere instead virtualIdentityHook so that it gets the most recent mail:3pane window (which is guaranteed to be a valid one).
There was a problem hiding this comment.
ok, think I understand this. But seems like the enigmail plugin does the same thing, in https://github.com/absorb-it/GMail-Conversation-View/blob/5a2d3ba278af4fba62bebc03807c736d9fbfc935/modules/plugins/enigmail.js#L544 ? Or do I misunderstand it?
There was a problem hiding this comment.
Yeah the Enigmail plugin might be wrong... nice catch!
There was a problem hiding this comment.
I'll fix that to call getMail3Pane() .
|
Hey, This has gotten much better! I'm really happy with the changes you made and they all seem to look solid. I still need to take a more detailed look at it (I'm still at the mozcamp right now) but you seem to be on the right track. I'm going to ask hiroshi to perform a detailed review of the various parts he knows (better than me). Thanks for the good work, jonathan |
| @@ -277,6 +277,8 @@ $.TokenList = function (input, settings) { | |||
| return false; | |||
| }); | |||
|
|
|||
| token_count++; | |||
There was a problem hiding this comment.
What happens if the user adds a recipient manually, by hitting "add cc", and the filling in the details of the recipient?
There was a problem hiding this comment.
I need to detect if a recipient is the first entered recipient, or if there was any other recipient added before (by the user, by quickreply or however). the token_count seems to be used only to limit the shown input-fields, therefore I thought it's ok to misuse this counter. This 'fix' is to count the preconfigured recipients in the init_list too, not sure if this is ok.
|
e8b8c96 : as suggested I removed the plugin-code completely to the virtualIdentity extension absorb-it/Virtual-Identity@7508872aa2cf74a11f a3d7f09 : change discussed with Hiroshi to enable cleanup of encrypted mail-content if sending was cancelled |
| @@ -446,7 +446,7 @@ let enigmailHook = { | |||
|
|
|||
| let uiFlags = nsIEnigmail.UI_INTERACTIVE; | |||
|
|
|||
| let identity = aAddress.identity | |||
| let identity = aAddress.params.identity | |||
There was a problem hiding this comment.
@shirosaki, can you confirm that this change is valid?
There was a problem hiding this comment.
This change would be valid.
Major changes to the plugin architecture. New functions to interact with the composition process, general cleanups to allow for a better interaction between various addons.
|
Ok, I've merged this pull request. The code quality has improved a lot since the first pull request, many thanks to Rene and Hiroshi for taking the time to polish this :). |
Hi Jonathan,
I cleaned the plugin code and tried to make the whole thing more useful to everybody. Please have a look and tell me what you think about it.
Thanks, regards, Rene