Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font selector to customization #1375

Closed
lukefretwell opened this issue Sep 6, 2018 · 2 comments

Comments

Projects
3 participants
@lukefretwell
Copy link

commented Sep 6, 2018

Would be great to have a font selector tool in customization so folks could easily change heading/body fonts.

Plugins I found with heavy adoption and most recent updates:

Fonts to add:

font-family: 'Source Sans Pro', sans-serif;
font-family: 'Lato', sans-serif;
font-family: 'Open Sans', sans-serif;
font-family: 'Roboto', sans-serif;
font-family: 'Montserrat', sans-serif;
font-family: 'Lora', serif;
font-family: 'Merriweather', serif;
font-family: 'Noto Serif', serif;
font-family: 'Roboto Slab', serif;
font-family: 'Source Serif Pro', serif;

and weights:

<link href="https://fonts.googleapis.com/css?family=Lato:400,700,900|Lora:400,700|Merriweather:400,700,900|Montserrat:400,700,900|Noto+Serif:400,700|Open+Sans:400,700,800|Roboto+Slab:400,700|Roboto:400,700,900|Source+Sans+Pro:400,700,900|Source+Serif+Pro:400,700" rel="stylesheet">

@lukefretwell lukefretwell referenced this issue Sep 6, 2018

Closed

Additional customization options #122

0 of 2 tasks complete
@lukefretwell

This comment has been minimized.

Copy link
Author

commented Dec 5, 2018

Removed this one as @aschmoe and I agreed having heading color customization defeats purpose of style sheet:

@lukefretwell lukefretwell added this to To do in UX Dec 5, 2018

@lukefretwell

This comment has been minimized.

Copy link
Author

commented Dec 20, 2018

@aschmoe I pulled the fonts and their weights. Looks like there's somewhat of a standard (400, 700, 900) so I'd change:

$light-weight:      300!default;
$regular-weight:    400!default;
$medium-weight:     500!default;
$bold-weight:       700!default;

to:

$light-weight:      300!default;
$regular-weight:    400!default;
$medium-weight:     700!default;
$bold-weight:       900!default;

It's probably fine to keep the 300 for light-weight, but I doubt that passes the accessibility test.

@jlyon jlyon added this to Longterm In Progress in proudcity/wp-proudcity Mar 29, 2019

@jlyon jlyon moved this from Longterm In Progress to Ready in proudcity/wp-proudcity Apr 26, 2019

@jlyon jlyon referenced this issue Apr 26, 2019

Closed

RELEASE 1.75.0 #1543

0 of 10 tasks complete

@jlyon jlyon closed this Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.