Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meeting post type #1401

Closed
jlyon opened this Issue Oct 1, 2018 · 18 comments

Comments

Projects
None yet
2 participants
@jlyon
Copy link
Contributor

jlyon commented Oct 1, 2018

Outstanding todos

  • Fix sort and display on teaser widget wp-content/plugins/wp-proud-core/modules/proud-teasers/proud-teasers.php line 506
  • Go through what displays on teaser
  • Go over display of post type
  • Responsive (100% width) video @aschmoe
  • How do we get these docs in elastic @aschmoe?
  • There currently is now way to remove a selected document
  • Push admin theme fixes for edit form
  • Infinite attachments field
  • Add to citytemplate, other sites that are interested

@kevindherman 's list

  • Change agenda to "agenda packet"
  • Completed meetings should include a "minutes" tab
  • Completed meeting page tabs should go in the order of agenda packet, minutes, video, contact info
  • Category label should display (this might've been missing because of the widget work)
  • Option to only have download button and not preview PDF would be nice
  • Hide video bookmarks if they don't create bookmarks

@jlyon jlyon added the ready label Oct 1, 2018

@jlyon jlyon referenced this issue Oct 1, 2018

Closed

RELEASE 1.63.0 #1398

9 of 9 tasks complete

jlyon added a commit that referenced this issue Oct 1, 2018

Hotfix 1.62.1, Sep 30 2018: Fixes for Meeting post type (wp-proud-cor…
…e, wp-proud-meeting, wp-proud-admin, wp-proud-theme) #1401
@jlyon

This comment has been minimized.

Copy link
Contributor Author

jlyon commented Oct 1, 2018

@kevindherman I pushed updates as a hotfix to Fairfax, Lucas, and beta.proudcity.com (u: proudcity, p: demo):

  • Fixed selection of files on the Meeting edit page
  • Templating display of Meeting page, including tabs, document preview, Youtube bookmark functionality
  • Initial attempt on list widgets (still needs work)

Examples:
https://beta.proudcity.com/meetings-new
https://beta.proudcity.com/meetings/upcoming-meeting/
https://beta.proudcity.com/meetings/completed-meeting/

@kevindherman

This comment has been minimized.

Copy link

kevindherman commented Oct 1, 2018

@jlyon thanks for fixing the file upload issue.

Feedback/suggestions from meeting with Fairfax:

1- Change agenda to "agenda packet"
2- Completed meetings should include a "minutes" tab
3- Completed meeting page tabs should go in the order of agenda packet, minutes, video, contact info
4- Category label should display (this might've been missing because of the widget work)
5- Option to only have download button and not preview PDF would be nice
6- Hide video bookmarks if they don't create bookmarks

Overall this is awesome!

@jlyon

This comment has been minimized.

Copy link
Contributor Author

jlyon commented Oct 2, 2018

@kevindherman I added your items to the checklist above. I figured out the issue with #2: I had the dates wrong; the completed event was in the future and upcoming was in the past.

The rest should be pretty quick. I think we should just go over them together in our Thurs mtg.

@kevindherman

This comment has been minimized.

Copy link

kevindherman commented Oct 2, 2018

@jlyon awesome. Looking forward to it.

@jlyon

This comment has been minimized.

Copy link
Contributor Author

jlyon commented Oct 4, 2018

@kevindherman I took care of most of the items on your list and pushed the latest to beta only. Have a look before our meeting.

  • I added the filename to the download button list (it was confusing without it)

Hide video bookmarks if they don't create bookmarks

This seemed to already be the case for me: https://beta.proudcity.com/meetings/completed-2/. I think we do need to try to make the video responsive (ie full-width in without bookmarks)

Category label should display (this might've been missing because of the widget work)

We should talk about this tomorrow. It looks like it's actually not displaying on most post types (News, Events).

@jlyon

This comment has been minimized.

Copy link
Contributor Author

jlyon commented Oct 10, 2018

1- can you add a media field for audio that works with SoundCloud? Like video this tab should only display if they have entered information
2- will the widget have a table view that displays name, agenda, minutes, video, audio?

@jlyon

This comment has been minimized.

Copy link
Contributor Author

jlyon commented Oct 10, 2018

@kevindherman

1- can you add a media field for audio that works with SoundCloud? Like video this tab should only display if they have entered information

I added this field to the edit page. It hasn't been added to the front-end yet (will happen in the next release). Do you think it should be its own tab, or should we change Video to Media and add it there?

2- will the widget have a table view that displays name, agenda, minutes, video, audio?

I can a table display to the widget in the next release.

jlyon added a commit to proudcity/wp-proud-theme that referenced this issue Oct 10, 2018

jlyon added a commit that referenced this issue Oct 10, 2018

@jlyon

This comment has been minimized.

Copy link
Contributor Author

jlyon commented Oct 10, 2018

@kevindherman I changed the Meeting list widget so it just displays both upcoming and completed meetings in one list. Upcoming meetings will display Add to Calendar and Get Directions buttons. Completed meetings will not.

I updated https://fairfax-ca.proudcity.com/meetings/ so that there is a meetings list at the bottom of the page. We can add more filters, etc to this.

jlyon added a commit to proudcity/wp-proud-theme that referenced this issue Oct 10, 2018

@kevindherman

This comment has been minimized.

Copy link

kevindherman commented Oct 10, 2018

@jlyon a few questions/comments after a quick looks:

1- Will the meeting list widget allow for you to select categories within the edit widget view or do you need to also place a meetings filter widget on that page? I didn't see either option so let me know what you're thinking on that front.
2- I think displaying upcoming and past meetings in one place is the right move. However, I think the table view that shows the supporting tabs as available will what people will use so the sooner the better on that.
3- Audio: should be it's own tab that is hidden if not used. Totally fine to come at a later release, this is the lowest priority just needed to know we can add it.

I think item one could be a blocker for Fairfax's launch so that they can put different meetings on different pages (departments, commissions, etc.). The table view is likely preferred but maybe not a blocker if we needed prioritize these ahead of the launch next week.

jlyon added a commit to proudcity/wp-proud-theme that referenced this issue Oct 16, 2018

jlyon added a commit to proudcity/wp-proud-core that referenced this issue Oct 16, 2018

@jlyon

This comment has been minimized.

Copy link
Contributor Author

jlyon commented Oct 16, 2018

@kevindherman I finished this up locally, but ran into issues when I tried to deploy it on Fairfax tonight (the whole widget disappeared), so I reverted back to what we had there previously.

This is what the table view will look like. Each label takes you to that specific tab on the Meeting detail page.
screenshot 43

This will get into the release this week.

@kevindherman

This comment has been minimized.

Copy link

kevindherman commented Oct 16, 2018

@jlyon that table looks great. Could you put the meeting name first and then date, content available? The meeting category can be hidden and just used for widget purposes.

We'll need to bump the launch back a week since they won't get to implement it until Friday morning.

@kevindherman

This comment has been minimized.

Copy link

kevindherman commented Oct 17, 2018

@jlyon I don't see it in the checklist above, unless it's part of the first item, but the meeting list widget should have the ability to select specific categories to display. Is that part of the updates for the release?

@jlyon

This comment has been minimized.

Copy link
Contributor Author

jlyon commented Oct 19, 2018

Order in table view is now

  • meeting name
  • date
  • content available?

Filter by category in the widget is now fixed. @kevindherman

@jlyon

This comment has been minimized.

Copy link
Contributor Author

jlyon commented Oct 19, 2018

Also changed Video to Media in the table view

@jlyon jlyon referenced this issue Oct 19, 2018

Closed

RELEASE 1.64.0 #1413

8 of 9 tasks complete
@jlyon

This comment has been minimized.

Copy link
Contributor Author

jlyon commented Oct 19, 2018

Added the table view, filtered to Town Council to https://fairfax-ca.proudcity.com/meetings/

@jlyon jlyon added this to the Release 1.63.0 milestone Oct 19, 2018

@kevindherman

This comment has been minimized.

Copy link

kevindherman commented Oct 23, 2018

@jlyon the date column in the table view displays the publish date not the date selected in the date picker for the meeting.

jlyon added a commit that referenced this issue Oct 23, 2018

@jlyon

This comment has been minimized.

Copy link
Contributor Author

jlyon commented Oct 23, 2018

@kevindherman I just fixed this as Hotfix 1.63.2 and pulled the update on Lucas and Fairfax.

@jlyon jlyon added the hotfix label Oct 23, 2018

@kevindherman

This comment has been minimized.

Copy link

kevindherman commented Oct 29, 2018

@jlyon when you select hide date from the meeting list table view it still shows the time. Should the time be another option to display/hide or be connected to date? Whatever you think is easiest.

https://fairfax-ca.proudcity.com/agendas-town-council/
screenshot 2018-10-29 15 33 59

@jlyon jlyon referenced this issue Nov 2, 2018

Closed

RELEASE 1.65.0 #1433

9 of 9 tasks complete

@jlyon jlyon modified the milestones: Release 1.63.0, Release 1.64.0 Nov 2, 2018

@jlyon jlyon closed this Nov 2, 2018

@jlyon jlyon removed the ready label Nov 2, 2018

jlyon added a commit that referenced this issue Nov 7, 2018

Hotfix 1.64.2, Nov 6 2018: Add Time to list of hide-able columns for …
…meetings table view #1401; Meetings: preserve line breaks in Agenda, Minutes #1435 (wp-proud-core, wp-proud-theme)

jlyon added a commit that referenced this issue Nov 7, 2018

Hotfix 1.64.2, Nov 6 2018: Add Time to list of hide-able columns for …
…meetings table view #1401; Meetings: preserve line breaks in Agenda, Minutes #1435 (wp-proud-core, wp-proud-theme)

@jlyon jlyon referenced this issue Nov 16, 2018

Closed

RELEASE 1.66.0 #1445

7 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.