Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color customization fix #1541

Closed
lukefretwell opened this issue Apr 9, 2019 · 3 comments

Comments

2 participants
@lukefretwell
Copy link

commented Apr 9, 2019

Can we make these changes to the customization tool to ensure it's more bullet-proof and clear on what's actually being changed?

  • Change 'Link color' description to 'Primary color.'
  • Make links, icon color and service center tabs the 'Primary color' (There are situations where the top bar will be white, which will make the icons white. Defaulting to the 'Primary color' will ensure this will never happen.).
  • Change 'Highlight' color description to 'Secondary color' and make hover links and service center highlighted tabs the 'Secondary color.'

Screen Shot 2019-04-09 at 2 59 18 PM (2)

@jlyon

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

color_highlight = Secondary
color_link = Primary

@jlyon jlyon added this to Longterm In Progress in proudcity/wp-proudcity Apr 12, 2019

@jlyon jlyon moved this from Longterm In Progress to Ready in proudcity/wp-proudcity Apr 12, 2019

@jlyon

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

Here's an example of how this looks now:

Screen Shot 2019-04-11 at 9 17 30 PM

This was referenced Apr 12, 2019

jlyon added a commit to proudcity/wp-proud-theme that referenced this issue Apr 12, 2019

jlyon added a commit to proudcity/wp-proud-theme that referenced this issue Apr 12, 2019

jlyon added a commit to proudcity/wp-proud-theme that referenced this issue Apr 12, 2019

jlyon added a commit that referenced this issue Apr 12, 2019

@jlyon jlyon moved this from Ready to Immediate In Progress in proudcity/wp-proudcity Apr 12, 2019

@jlyon

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

@lukefretwell @kevindherman @aschmoe after more testing in the release, we reverted this change. We will need to do more testing/planning before pushing this probably.

new background buttons
Screenshot of Home - City of Warr Acres

vs old …
Screenshot of Home - City of Warr Acres (1)

@jlyon jlyon reopened this Apr 12, 2019

@jlyon jlyon referenced this issue Apr 26, 2019

Open

RELEASE 1.76.0 #1546

5 of 10 tasks complete

@jlyon jlyon moved this from Immediate In Progress to Ready in proudcity/wp-proudcity Apr 26, 2019

@jlyon jlyon closed this Apr 26, 2019

@jlyon jlyon referenced this issue May 10, 2019

Open

RELEASE 1.77.0 #1557

0 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.