Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page layout templates #1880

Open
lukefretwell opened this issue Sep 7, 2021 · 3 comments
Open

Update page layout templates #1880

lukefretwell opened this issue Sep 7, 2021 · 3 comments

Comments

@lukefretwell
Copy link
Contributor

@jlyon I reviewed/updated the pages associated with the layout templates, but it looks like we need to update the respective layouts. I copied the Trello card from last time and add you to it in case you need a reference. Looks like there are a few that don't work as good since @aschmoe update the widgets for accessibility.

@kevindherman
Copy link

@lukefretwell can you flag the ones that need to be updated using city-template? We can then make the necessary changes and then @jlyon can deploy the updated layouts.

@kevindherman kevindherman self-assigned this Sep 13, 2021
@kevindherman kevindherman moved this from Backlog to Immediate In Progress in proudcity/wp-proudcity Sep 13, 2021
@lukefretwell
Copy link
Contributor Author

@jlyon @kevindherman can't we just overwrite all of them?

@kevindherman
Copy link

@lukefretwell

The layout library uses exported pagebuilder files so if a layout needs to be updated or a new one added @jlyon just needs a link to the page on city template. If you could provide links to the pages you adjusted it will make it more efficient and limit confusion on if the right page is being exported/imported.

Can you provide those links with the name of layout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants