Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links not underlined in agenda packet tab #2099

Closed
lukefretwell opened this issue Sep 2, 2022 · 4 comments
Closed

Links not underlined in agenda packet tab #2099

lukefretwell opened this issue Sep 2, 2022 · 4 comments

Comments

@lukefretwell
Copy link
Contributor

Source

Fairfax

Describe the bug

The links in the agenda packet tab aren't underlined. It appears this is just for those that are in an li.

I added this custom CSS to fix it on the Fairfax website, but we should add to the main CSS file:

#tab-agenda-packet li a, #tab-agenda-packet li a:visited {
	text-decoration: underline;
}

To Reproduce
Steps to reproduce the behavior:

  1. Go to ['...'](https://www.townoffairfax.org/meetings/town-council-meeting-august-9-2022/)
  2. Click on 'Agend packet' tab
  3. Inspect code to remove custom CSS
  4. See error

Expected behavior

Links in main content aren't should be underlined.

Screenshots

N/A

Desktop (please complete the following information):

N/A

Smartphone (please complete the following information):

N/A

Additional context

N/A

@curtismchale curtismchale added this to Backlog in ProudCity project board via automation Sep 6, 2022
@curtismchale curtismchale self-assigned this Sep 6, 2022
@curtismchale
Copy link
Contributor

@lukefretwell I took a look at the site and I don't see any custom CSS rules.

CleanShot 2022-09-06 at 13 56 31@2x

I also checked Beta and it appears that the links are working there for agenda packets without further CSS work.

CleanShot 2022-09-06 at 14 02 46@2x

You won't be able to switch to the agenda packet tab until I deploy the latest build process update in a few minutes.

@lukefretwell
Copy link
Contributor Author

@curtismchale see the 'Appoint' link (at the bottom of the screenshot) which is not underlined. I can't figure out why it's not underlined, but looks like it's for a list item.

@curtismchale
Copy link
Contributor

@lukefretwell yup I see it. There doesn't appear to be a blank rule for links to make them underlined. The rule that applies to the rest of the content matches on p a. I'll look at a better generic rule...without affecting everything else.

@curtismchale
Copy link
Contributor

@lukefretwell new rules going up with the new build to Beta shortly.

@curtismchale curtismchale moved this from Backlog to Ready for release in ProudCity project board Sep 6, 2022
ProudCity project board automation moved this from Ready for release to Done Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants