Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker module logs error for normal operation #318

Closed
7 tasks
iramiller opened this issue May 20, 2021 · 0 comments · Fixed by #319
Closed
7 tasks

Marker module logs error for normal operation #318

iramiller opened this issue May 20, 2021 · 0 comments · Fixed by #319
Assignees
Labels
bug Something isn't working marker Marker Module
Projects
Milestone

Comments

@iramiller
Copy link
Member

Summary of Bug

When a normal mint/burn action is performed the AdjustCirculation method logs an error about adjusting circulation amounts.

Version

1.3.0-HEAD

Steps to Reproduce

Perform a mint or burn on a marker, note error message in node log output.

ctx.Logger().Error(
fmt.Sprintf("Current %s supply is NOT at the required amount, minting %s to required supply level",
marker.GetDenom(), offset))

And

ctx.Logger().Error(
fmt.Sprintf("Current %s supply is NOT at the required amount, burning %s to required supply level",
marker.GetDenom(), offset))

Remediation

  • Change circulation adjustment to log at info.

  • Add an error log statement to ABCI when an adjustment is performed

    if !requiredSupply.IsEqual(currentSupply) {

  • Add a telemetry logging statement to the ABCI method to measure time required (bonus missing item)

	defer telemetry.ModuleMeasureSince(types.ModuleName, time.Now(), telemetry.MetricKeyBeginBlocker)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller iramiller added bug Something isn't working marker Marker Module labels May 20, 2021
@iramiller iramiller added this to the v1.4.0 milestone May 20, 2021
@iramiller iramiller self-assigned this May 20, 2021
@iramiller iramiller added this to Triage in Mainnet via automation May 20, 2021
Mainnet automation moved this from Triage to Done May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working marker Marker Module
Projects
Mainnet
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant