New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more libraries #9

Merged
merged 3 commits into from Jun 8, 2015

Conversation

Projects
None yet
2 participants
@glasserc
Contributor

glasserc commented Jun 8, 2015

ig has somewhat strict constraints on what it will compile against. In particular:

  • attoparsec, which is not a direct dependency of ig, has to be less than 0.12.
  • conduit can be either 1.0 series or 1.1 series. It seems from the changelog at snoyberg/conduit@e03ee0e that no breaking changes are expected unless you import .Internal.
  • monad-control > 1.0 breaks everything.

This branch loosens those constraints by deleting the direct dependency on attoparsec (leaving our direct dependencies to deal with it), widening the constraint on conduit in the 1.1 series case, and adding support for the new monad-control. This is based on DanielG/ghc-mod#423 and https://hackage.haskell.org/package/monad-control-0.3.3.1/docs/Control-Monad-Trans-Control.html#g:2, and they seem to compile, although I can't claim that I understand them thoroughly enough to promise that they work.

glasserc added some commits Jun 8, 2015

cabal: support newer attoparsec, conduit
We don't even depend directly on attoparsec, so we needn't specify its
versions here.

meteficha added a commit that referenced this pull request Jun 8, 2015

@meteficha meteficha merged commit eb4dde8 into prowdsponsor:master Jun 8, 2015

@meteficha

This comment has been minimized.

Show comment
Hide comment
@meteficha

meteficha Jun 8, 2015

Member

Awesome, thanks! Released as ig-0.2.2.

Member

meteficha commented Jun 8, 2015

Awesome, thanks! Released as ig-0.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment