Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Version 2.7.0 extra75 reports default SecurityGroups as unused #1001

Closed
jansepke opened this issue Jan 27, 2022 · 2 comments · Fixed by #1006
Closed

[Bug]: Version 2.7.0 extra75 reports default SecurityGroups as unused #1001

jansepke opened this issue Jan 27, 2022 · 2 comments · Fixed by #1006
Labels

Comments

@jansepke
Copy link
Contributor

What happened?
After upgrading to prowler 2.7.0 existing default SecurityGroups that are not being used are now a failure in extra75 check. Before this version it was only an INFO.

Expected behavior
7.5 [extra75] Ensure there are no Security Groups not being used - ec2 [Informational]
INFO! eu-central-1: sg-XYZ is not being used - default security group

Actual behavior
7.5 [extra75] Ensure there are no Security Groups not being used - ec2 [Informational]
FAIL! eu-central-1: sg-XYZ is not being used!

From where are you running Prowler?
Please, complete the following information:

  • Resource: EC2 instance
  • OS: Amazon Linux 2
  • AWS-CLI Version [aws --version]: 1.22.42
  • Prowler Version [./prowler -V]: 2.7.0
  • Shell and version: bash
  • Others:
@jansepke jansepke added the bug label Jan 27, 2022
@toniblyx
Copy link
Member

I think there is a misunderstanding here, this check has worked that way since it was written. If a SG is not in use it is a FAIL.

@jansepke
Copy link
Contributor Author

OK I found the bug: this commit 2b28147 changed the content of the variables, I will create a PR to fix it.

toniblyx pushed a commit that referenced this issue Jan 27, 2022
regression in extra75

Co-authored-by: Jan Sepke <jan.sepke@jungheinrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants