Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag -q shows Check_Results "WARNING" additionally instead of only "FAIL" #884

Closed
gregorschulz opened this issue Sep 28, 2021 · 4 comments
Closed

Comments

@gregorschulz
Copy link

The -q flag doesn't show only the "FAIL"s but also the WARNINGs from the exclusions when using -w whitelist.txt.

Is this by intention?

@gregorschulz gregorschulz changed the title Flag -q shows Check_Result "WARNING" additionally instead of only "FAIL" Flag -q shows Check_Results "WARNING" additionally instead of only "FAIL" Sep 28, 2021
@toniblyx
Copy link
Member

toniblyx commented Oct 1, 2021

Hi @gregorschulz, yes, that is an expected behavior. WARNING is shown when a resource is excluded, it is just to take it into consideration.

@gregorschulz
Copy link
Author

Ok, but then I would suggest to adjust the documentation for -q:
https://github.com/toniblyx/prowler#show-or-log-only-fails

@w0rmr1d3r
Copy link
Contributor

Hi @toniblyx & @gregorschulz !

I did a PR #890 updating the documentation.
Tell me what you think to see if it's clearer that way.

Cheers!

toniblyx added a commit that referenced this issue Oct 4, 2021
#884) @w0rmr1d3r

Updated documentation regarding a confusion with the `-q` option (issue #884) @w0rmr1d3r
@toniblyx
Copy link
Member

toniblyx commented Oct 4, 2021

Thanks for reporting it @gregorschulz and for the enhancements @w0rmr1d3r!!

@toniblyx toniblyx closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants