feat(check): New check7172 for S3 Bucket ACLs

[jeffmaley]

Context

#1022

Description

This pr adds a check (7172) to look for bucket ACLs

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[lazize]

Why execute two CLI commands if one is enough?

Variable LIST_OF_BUCKETS can be used for both cases. Access check and loop iteration.
You just need to remove | xargs -n1.

| xargs -n1 will give a better view of the output, but as it will be used by checking error and to perform for loop iteration, it doesn't need a better view. Both cases work fine with a "not so beautiful" output.
Variable LIST_OF_BUCKETS is not used to output details to user.

[jeffmaley]

My thought was to keep the two bits separate. If we need to change the access check or bucket controls check, we don't have to refactor the other piece. If you'd rather they be combined, I will make the change.

[lazize]

There is a throttling that impacts Prowler when it is running inside AWS, so I believe fewer request is better.
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/throttling.html

But let's wait maintainer people to comment.

[toniblyx]

I agree with @lazize the less the better regardless of cli and boto3 underneath.

[toniblyx]

and thank you @jeffmaley for the check!

[jeffmaley]

I've condensed the access check into the s3 check itself and removed the extra api call.

[toniblyx]

LGTM