Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(extra760): Error handling #1025

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Conversation

lazize
Copy link
Contributor

@lazize lazize commented Feb 3, 2022

Context

Missing permission was exposing AccessDenied error message.
Also missing check was generating false positive.

Description

Add check to validate access denied when get function from Lambda.

Issue #1014

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lazize
Copy link
Contributor Author

lazize commented Feb 3, 2022

Please check additional questions on #1014

@lazize
Copy link
Contributor Author

lazize commented Feb 3, 2022

$ ./prowler -p default -f sa-east-1 -c extra760
                          _
  _ __  _ __ _____      _| | ___ _ __
 | '_ \| '__/ _ \ \ /\ / / |/ _ \ '__|
 | |_) | | | (_) \ V  V /| |  __/ |
 | .__/|_|  \___/ \_/\_/ |_|\___|_|v2.7.0-24January2022
 |_| the handy cloud security tool

 Date: Wed Feb  2 22:59:37 -03 2022

 Color code for results:
 -  INFO (Information)
 -  PASS (Recommended value)
 -  WARNING (Ignored by whitelist)
 -  FAIL (Fix required)

 This report is being generated using credentials below:

 AWS-CLI Profile: [default] AWS API Region: [sa-east-1] AWS Filter Region: [sa-east-1]
 AWS Account: [xxxx5262] UserId: [AROAxxxx:xxxxx]
 Caller Identity ARN: [arn:aws:sts::xxxx5262:assumed-role/xxxx/xxxxxx]

7.60 [extra760] Find secrets in Lambda functions code  - lambda [Critical]
       PASS! sa-east-1: No secrets found in Lambda function dump-request code
       PASS! sa-east-1: No secrets found in Lambda function test code
$ ./prowler -p default -f sa-east-1 -c extra760
                          _
  _ __  _ __ _____      _| | ___ _ __
 | '_ \| '__/ _ \ \ /\ / / |/ _ \ '__|
 | |_) | | | (_) \ V  V /| |  __/ |
 | .__/|_|  \___/ \_/\_/ |_|\___|_|v2.7.0-24January2022
 |_| the handy cloud security tool

 Date: Wed Feb  2 23:06:08 -03 2022

 Color code for results:
 -  INFO (Information)
 -  PASS (Recommended value)
 -  WARNING (Ignored by whitelist)
 -  FAIL (Fix required)

 This report is being generated using credentials below:

 AWS-CLI Profile: [default] AWS API Region: [sa-east-1] AWS Filter Region: [sa-east-1]
 AWS Account: [xxxx5262] UserId: [AROAxxxx:xxxxx]
 Caller Identity ARN: [arn:aws:sts::xxxx5262:assumed-role/xxxx/xxxxxx]

7.60 [extra760] Find secrets in Lambda functions code  - lambda [Critical]
       INFO! sa-east-1: Access Denied trying to get Lambda functions
       INFO! sa-east-1: Access Denied trying to get Lambda functions

@lazize lazize changed the title [extra760] Fix AccessDenied issue Fix(extra760): Error handling Feb 3, 2022
@toniblyx toniblyx self-requested a review February 4, 2022 17:04
@toniblyx toniblyx merged commit 3ecb5db into prowler-cloud:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants