Conversation
n4ch04
changed the title
n4ch04
changed the title
jfagoagas
requested changes
Feb 3, 2022
| @@ -169,14 +169,17 @@ textFail(){ | |||
| colorcode="$BAD" | |||
| while read -r i; do | |||
Member
There was a problem hiding this comment.
What is this i?
I think a more expressive name would be better.
Contributor
Author
There was a problem hiding this comment.
changed, variable is called excluded_item instead
| # Checked value is the second field of log message divided by spaces | ||
| checked_value=$(awk '{print $2}' <<< $1) | ||
| echo | ||
| if [[ ${ignore_check_name} != "${CHECK_NAME}" ]]; then |
Member
There was a problem hiding this comment.
Suggested change
| if [[ ${ignore_check_name} != "${CHECK_NAME}" ]]; then | |
| if [[ "${ignore_check_name}" != "${CHECK_NAME}" ]]; then |
| fi | ||
| if [[ $1 =~ ${resource_value} ]]; then | ||
| # To set WARNING flag both values must be exactly the same | ||
| if [[ ${checked_value} == ${resource_value} ]]; then |
Member
There was a problem hiding this comment.
Suggested change
| if [[ ${checked_value} == ${resource_value} ]]; then | |
| if [[ "${checked_value}" == "${resource_value}" ]]; then |
| # To set WARNING flag both values must be exactly the same | ||
| if [[ ${checked_value} == ${resource_value} ]]; then | ||
| level="WARNING" | ||
| colorcode="$WARNING" |
Member
There was a problem hiding this comment.
Suggested change
| colorcode="$WARNING" | |
| colorcode="${WARNING}" |
| resource_value=$(awk -F ":" '{print $2}' <<< $i) | ||
| # Checked value is the second field of log message divided by spaces | ||
| checked_value=$(awk '{print $2}' <<< $1) | ||
| echo |
… whitelisted values
jfagoagas
approved these changes
Feb 3, 2022
toniblyx
deleted the
PRWLR-38-whitelist-does-not-match-exact-s-3-bucket-961
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
#961
Description
Logic of whitelisting matching reformulated to exactly macth input
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.