Skip to content

Conversation

@lazize
Copy link
Contributor

@lazize lazize commented Feb 4, 2022

Context

AWS CLI query was return wrong information.

Missing error handling.

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Fix CLI query and add error handling.

Checks:

  • extra715
  • extra716
  • extra780
  • extra781
  • extra782
  • extra783
  • extra784
  • extra785
  • extra788
  • extra7101

Fix issue #989

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check extra781, extra782, extra783, extra784 and extra785
@lazize lazize requested review from a team, n4ch04 and toniblyx February 4, 2022 23:31
@lazize
Copy link
Contributor Author

lazize commented Feb 4, 2022

$ ./prowler -p default -f sa-east-1 -c extra781,extra782,extra783,extra784,extra785
                          _
  _ __  _ __ _____      _| | ___ _ __
 | '_ \| '__/ _ \ \ /\ / / |/ _ \ '__|
 | |_) | | | (_) \ V  V /| |  __/ |
 | .__/|_|  \___/ \_/\_/ |_|\___|_|v2.7.0-24January2022
 |_| the handy cloud security tool

 Date: Fri Feb  4 20:23:58 -03 2022

 Color code for results:
 -  INFO (Information)
 -  PASS (Recommended value)
 -  WARNING (Ignored by whitelist)
 -  FAIL (Fix required)

 This report is being generated using credentials below:

 AWS-CLI Profile: [default] AWS API Region: [sa-east-1] AWS Filter Region: [sa-east-1]
 AWS Account: [xxxx5262] UserId: [AROAxxxx:xxxx]
 Caller Identity ARN: [arn:aws:sts::xxxx5262:assumed-role/xxxx/xxxx]

7.81 [extra781] Check if Amazon Elasticsearch Service (ES) domains has encryption at-rest enabled - es [Medium]
       FAIL! sa-east-1: Amazon ES domain test-es does not have encryption at-rest enabled
7.82 [extra782] Check if Amazon Elasticsearch Service (ES) domains has node-to-node encryption enabled - es [Medium]
       FAIL! sa-east-1: Amazon ES domain test-es does not have node-to-node encryption enabled
7.83 [extra783] Check if Amazon Elasticsearch Service (ES) domains has enforce HTTPS enabled - es [Medium]
       PASS! sa-east-1: Amazon ES domain test-es has enforce HTTPS enabled
7.84 [extra784] Check if Amazon Elasticsearch Service (ES) domains internal user database enabled - es [Medium]
       PASS! sa-east-1: Amazon ES domain test-es does not have internal user database enabled
7.85 [extra785] Check if Amazon Elasticsearch Service (ES) domains have updates available - es [Low]
       PASS! sa-east-1: Amazon ES domain test-es vOpenSearch_1.1 does not have have updates available

@lazize lazize changed the title Fix(extra78[1-5]): Improve AWS CLI query and add error handling Fix(ES): Improve AWS CLI query and add error handling Feb 7, 2022
@jfagoagas jfagoagas added status/waiting-for-revision Waiting for maintainer's revision severity/high Bug capable of collapsing large parts of the execution. labels Feb 8, 2022
@toniblyx toniblyx changed the title Fix(ES): Improve AWS CLI query and add error handling Fix(ES): Improve AWS CLI query and add error handling for ElasticSearch/OpenSearch checks Feb 28, 2022
@toniblyx toniblyx requested review from toniblyx and removed request for n4ch04 February 28, 2022 18:39
@toniblyx toniblyx self-assigned this Feb 28, 2022
@toniblyx toniblyx self-requested a review February 28, 2022 18:43
@toniblyx toniblyx requested review from jfagoagas, n4ch04 and toniblyx and removed request for jfagoagas February 28, 2022 18:44
@toniblyx toniblyx merged commit 5f0a5b5 into prowler-cloud:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

severity/high Bug capable of collapsing large parts of the execution. status/waiting-for-revision Waiting for maintainer's revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants