Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(check41/42): Added tcp protocol filter to query #1035

Conversation

n4ch04
Copy link
Contributor

@n4ch04 n4ch04 commented Feb 8, 2022

Context

Check41 and Check42 returns false positives when gre protocol rule is included in sg

Description

When working with check41 and check42 some false positives rose up due to not including protocol filtering

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@n4ch04 n4ch04 requested a review from a team as a code owner February 8, 2022 07:57
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @n4ch04, please check above comments in order to merge this PR.

checks/check41 Outdated Show resolved Hide resolved
checks/check42 Outdated Show resolved Hide resolved
toniblyx
toniblyx previously approved these changes Feb 8, 2022
Co-authored-by: Pepe Fagoaga <pepe@verica.io>
@n4ch04 n4ch04 requested a review from jfagoagas February 8, 2022 15:44
Co-authored-by: Pepe Fagoaga <pepe@verica.io>
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @n4ch04

@StephenKing
Copy link

LGTM, very much appreciated!

@n4ch04 n4ch04 merged commit b4669a2 into master Feb 11, 2022
@n4ch04 n4ch04 deleted the PRWLR-39-false-positive-with-checks-41-and-42-when-using-gre-as-ip-protocol-ip-protocol-47-964 branch February 11, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-revision Waiting for maintainer's revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants