fix(extra736): Recover only Customer Managed KMS keys #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n4ch04
approved these changes
Feb 9, 2022
jfagoagas
deleted the
PRWLR-42-check-number-7-36-recover-customer-managed
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Previously, check
extra736only checked if KMS Keys with an alias configured were publicly exposed.Description
Right now, this control recovers every KMS Key at the account and checks the
KeyManagerproperty to extract only the policy for the ones not managed by AWS. So, with that KMS Keys without an alias configured are also audited.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.