fix(include/outputs):Rolling back whitelist checking to RE check #1037
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
requested changes
Feb 8, 2022
| resource_value=$(awk -F ":" '{print $2}' <<< $excluded_item) | ||
| # Checked value is the second field of log message divided by spaces | ||
| checked_value=$(awk '{print $2}' <<< $1) | ||
| checked_value=$1 |
Member
There was a problem hiding this comment.
Please link $1 to a local variable with a proper name to better follow the execution flow.
Also, quote variables like "${varName}"
toniblyx
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
With last change to exactly match elements included in the whitelist and log info returned whitelist feature was broken not whitelisting multitude of items
Description
Fix the feature, rolling back to regular expression checking to find if whitelisted element is included into log message
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.