Skip to content

Added timestamp to temp folders for secrets related checks#1041

Merged
toniblyx merged 1 commit into
prowler-cloud:masterfrom
sectoramen:fabio-dev
Mar 2, 2022
Merged

Added timestamp to temp folders for secrets related checks#1041
toniblyx merged 1 commit into
prowler-cloud:masterfrom
sectoramen:fabio-dev

Conversation

@sectoramen
Copy link
Copy Markdown
Contributor

Context

Added a timestamp to the checks. When running prowler in parallel for multiple zones, the SECRETS_TEMP_FOLDER file is overwritten"

Description

The five checks have been changed to include a timestamp in the file name to avoid race conditions:

  • Before: SECRETS_TEMP_FOLDER="$PROWLER_DIR/secrets-$ACCOUNT_NUM"
  • After: SECRETS_TEMP_FOLDER="$PROWLER_DIR/secrets-$ACCOUNT_NUM-$PROWLER_START_TIME"

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sectoramen sectoramen requested review from a team, jfagoagas and toniblyx February 10, 2022 22:33
@jfagoagas jfagoagas added the status/needs-triage Issue pending triage label Feb 11, 2022
Copy link
Copy Markdown
Member

@toniblyx toniblyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfagoagas jfagoagas added severity/medium Results in some unexpected or undesired behavior. status/waiting-for-revision Waiting for maintainer's revision and removed status/needs-triage Issue pending triage labels Feb 15, 2022
@toniblyx toniblyx changed the title Added Timestamp to 5 checks Added timestamp to temp folders for secrets related checks Mar 1, 2022
@toniblyx toniblyx self-requested a review March 2, 2022 14:10
@toniblyx toniblyx merged commit 2d5ac82 into prowler-cloud:master Mar 2, 2022
@toniblyx
Copy link
Copy Markdown
Member

toniblyx commented Mar 2, 2022

Thanks @sectoramen

@sectoramen sectoramen deleted the fabio-dev branch March 2, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

severity/medium Results in some unexpected or undesired behavior. status/waiting-for-revision Waiting for maintainer's revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants