Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make python3 default in Dockerfile #1043

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Make python3 default in Dockerfile #1043

merged 1 commit into from
Mar 2, 2022

Conversation

sectoramen
Copy link
Contributor

@sectoramen sectoramen commented Feb 14, 2022

Context

Although python3 was installed. the /usr/bin directory still had a symlink to python2. Fixed by removing the symlink and creating a new one that points to python3. Verified with

[host] Prowler % docker run --rm -it --entrypoint /bin/bash prowler:latest
[prowler@302c9cbd6e18 prowler]$ ls -al /usr/bin/pytho*
lrwxrwxrwx 1 root root 16 Feb 14 19:19 /usr/bin/python -> /usr/bin/python3
lrwxrwxrwx 1 root root 9 Feb 7 22:13 /usr/bin/python2 -> python2.7
-rwxr-xr-x 1 root root 7048 Jun 10 2021 /usr/bin/python2.7
lrwxrwxrwx 1 root root 9 Feb 14 19:19 /usr/bin/python3 -> python3.7
-rwxr-xr-x 2 root root 7048 Jun 3 2021 /usr/bin/python3.7
-rwxr-xr-x 2 root root 7048 Jun 3 2021 /usr/bin/python3.7m
[prowler@302c9cbd6e18 prowler]$

Description

Removed symlink /usr/bin/python -> /usr/bin/python2 and created stymlink /usr/bin/python -> /usr/bin/python3

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sectoramen sectoramen requested a review from a team as a code owner February 14, 2022 19:25
Copy link
Member

@toniblyx toniblyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfagoagas jfagoagas added severity/low Bug won't result in any noticeable breakdown of the execution. status/waiting-for-revision Waiting for maintainer's revision labels Feb 15, 2022
@toniblyx toniblyx changed the title enabled python3 Make python3 default in Dockerfile Mar 1, 2022
@toniblyx toniblyx merged commit 31cefa5 into prowler-cloud:master Mar 2, 2022
@toniblyx
Copy link
Member

toniblyx commented Mar 2, 2022

Thanks @sectoramen

@sectoramen sectoramen deleted the fabio-dev-docker branch March 2, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/low Bug won't result in any noticeable breakdown of the execution. status/waiting-for-revision Waiting for maintainer's revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants