Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metadata): Include account metadata in Prowler assessments #1049

Merged

Conversation

toniblyx
Copy link
Member

Context

This code provide additional account information to each csv and json output if Prowler can get information from the AWS organizations management account.

  "Account Email": 
  "Account Name":
  "Account ARN": 
  "Account Organization": 
  "Account tags": 

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toniblyx toniblyx requested review from a team, jfagoagas and n4ch04 February 22, 2022 09:46
@jfagoagas jfagoagas changed the title Prwlr 127 include account metadata in prowler assessments feat(metadata): Include account metadata in Prowler assessments Feb 25, 2022
Use assume_role backing up normal assumed credentials to assume management account and then restore it to old ones
@n4ch04 n4ch04 force-pushed the PRWLR-127-include-account-metadata-in-prowler-assessments branch from 860c47d to a0d4a8a Compare March 14, 2022 14:42
prowler Outdated Show resolved Hide resolved
prowler Outdated Show resolved Hide resolved
prowler Outdated Show resolved Hide resolved
prowler Outdated Show resolved Hide resolved
prowler Outdated Show resolved Hide resolved
include/organizations_metadata Outdated Show resolved Hide resolved
include/organizations_metadata Outdated Show resolved Hide resolved
include/organizations_metadata Outdated Show resolved Hide resolved
include/organizations_metadata Outdated Show resolved Hide resolved
include/organizations_metadata Outdated Show resolved Hide resolved
include/organizations_metadata Outdated Show resolved Hide resolved
@jfagoagas
Copy link
Member

Are we forcing to use the same role name for the Management account (to recover Organizations metadata) and the account to be audited?

@toniblyx
Copy link
Member Author

yes, that is on purpose to simplify.

@toniblyx toniblyx added feature severity/medium Results in some unexpected or undesired behavior. labels Mar 15, 2022
@jfagoagas jfagoagas requested review from sergargar, a team and jfagoagas March 15, 2022 09:56
@toniblyx toniblyx added the status/waiting-for-revision Waiting for maintainer's revision label Mar 15, 2022
sergargar
sergargar previously approved these changes Mar 15, 2022
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it is a great feature!

n4ch04
n4ch04 previously approved these changes Mar 15, 2022
@jfagoagas jfagoagas dismissed stale reviews from n4ch04 and sergargar via b10354a March 15, 2022 17:21
@jfagoagas jfagoagas force-pushed the PRWLR-127-include-account-metadata-in-prowler-assessments branch 2 times, most recently from b10354a to 477ba3a Compare March 15, 2022 17:33
Reformulate to extract AWS Organizations metadata
@jfagoagas jfagoagas force-pushed the PRWLR-127-include-account-metadata-in-prowler-assessments branch from 477ba3a to 414553f Compare March 15, 2022 17:34
n4ch04
n4ch04 previously approved these changes Mar 16, 2022
@n4ch04
Copy link
Contributor

n4ch04 commented Mar 16, 2022

@jfagoagas jfagoagas removed the status/waiting-for-revision Waiting for maintainer's revision label Mar 16, 2022
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!!!!!

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed!

@sergargar sergargar merged commit 365b396 into master Mar 16, 2022
@sergargar sergargar deleted the PRWLR-127-include-account-metadata-in-prowler-assessments branch March 16, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature severity/medium Results in some unexpected or undesired behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants