Skip to content

feat(metadata): Include account metadata in Prowler assessments#1049

Merged
MrCloudSec merged 8 commits intomasterfrom
PRWLR-127-include-account-metadata-in-prowler-assessments
Mar 16, 2022
Merged

feat(metadata): Include account metadata in Prowler assessments#1049
MrCloudSec merged 8 commits intomasterfrom
PRWLR-127-include-account-metadata-in-prowler-assessments

Conversation

@toniblyx
Copy link
Copy Markdown
Member

@toniblyx toniblyx commented Feb 22, 2022

Context

This code provide additional account information to each csv and json output if Prowler can get information from the AWS organizations management account.

  "Account Email": 
  "Account Name":
  "Account ARN": 
  "Account Organization": 
  "Account tags":

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toniblyx toniblyx requested review from a team, jfagoagas and n4ch04 February 22, 2022 09:46
@jfagoagas jfagoagas changed the title Prwlr 127 include account metadata in prowler assessments feat(metadata): Include account metadata in Prowler assessments Feb 25, 2022
n4ch04 added 2 commits March 14, 2022 15:41
@n4ch04
chore(prowler): get accounts metadata
411deb7 
Use assume_role backing up normal assumed credentials to assume management account and then restore it to old ones
@n4ch04
fix(orgs metadata): deleted assume_role_orgs
a0d4a8a
@n4ch04 n4ch04 force-pushed the PRWLR-127-include-account-metadata-in-prowler-assessments branch from 860c47d to a0d4a8a Compare March 14, 2022 14:42
jfagoagas
jfagoagas requested changes Mar 14, 2022
View reviewed changes
jfagoagas
jfagoagas requested changes Mar 14, 2022
View reviewed changes
jfagoagas
jfagoagas reviewed Mar 14, 2022
View reviewed changes
@jfagoagas
Copy link
Copy Markdown
Member

jfagoagas commented Mar 14, 2022

Are we forcing to use the same role name for the Management account (to recover Organizations metadata) and the account to be audited?

@toniblyx
Copy link
Copy Markdown
Member Author

toniblyx commented Mar 15, 2022

yes, that is on purpose to simplify.

@toniblyx toniblyx added feature severity/medium Results in some unexpected or undesired behavior. labels Mar 15, 2022
@jfagoagas jfagoagas requested review from a team, MrCloudSec and jfagoagas March 15, 2022 09:56
@toniblyx toniblyx added the status/waiting-for-revision Waiting for maintainer's revision label Mar 15, 2022
MrCloudSec
MrCloudSec previously approved these changes Mar 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it is a great feature!

n4ch04
n4ch04 previously approved these changes Mar 15, 2022
View reviewed changes
@jfagoagas jfagoagas dismissed stale reviews from n4ch04 and MrCloudSec via b10354a March 15, 2022 17:21
@jfagoagas jfagoagas force-pushed the PRWLR-127-include-account-metadata-in-prowler-assessments branch 2 times, most recently from b10354a to 477ba3a Compare March 15, 2022 17:33
@jfagoagas
refactor(organization_metadata)
414553f 
Reformulate to extract AWS Organizations metadata
@jfagoagas jfagoagas force-pushed the PRWLR-127-include-account-metadata-in-prowler-assessments branch from 477ba3a to 414553f Compare March 15, 2022 17:34
n4ch04
n4ch04 previously approved these changes Mar 16, 2022
View reviewed changes
@n4ch04
Copy link
Copy Markdown
Contributor

n4ch04 commented Mar 16, 2022

@jfagoagas jfagoagas removed the status/waiting-for-revision Waiting for maintainer's revision label Mar 16, 2022
@jfagoagas jfagoagas requested a review from MrCloudSec March 16, 2022 15:25
jfagoagas
jfagoagas approved these changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!!!!!

MrCloudSec
MrCloudSec approved these changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed!

@MrCloudSec MrCloudSec merged commit 365b396 into master Mar 16, 2022
@MrCloudSec MrCloudSec deleted the PRWLR-127-include-account-metadata-in-prowler-assessments branch March 16, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfagoagas jfagoagas jfagoagas approved these changes

+2 more reviewers

@MrCloudSec MrCloudSec MrCloudSec approved these changes

@n4ch04 n4ch04 n4ch04 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

severity/medium Results in some unexpected or undesired behavior.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@toniblyx @jfagoagas @n4ch04 @MrCloudSec