fix: extra7167 Advanced Shield and CloudFront bug parsing None output without distributions #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toniblyx
changed the title
toniblyx
requested changes
Mar 3, 2022
Member
|
Awesome, thanks @NMuee! |
toniblyx
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
My AWS account is encountering false positive with extra7167
We do not have any cloudfront distribution, yet they are being flagged as
"Cloudfront distribution None is not protected by AWS Shield Advanced"
due to
aws cloudfront list-distributions --profile $profile --query 'DistributionList.Items[*].[Id,ARN]' --output textis outputting as 'None' even thought there is no cloudfront distribution.Description
In the if statement, Instead of detecting if there is any value in the variable $LIST_OF_CLOUDFRONT_DISTRIBUTIONS, I updated the code with
$LIST_OF_CLOUDFRONT_DISTRIBUTIONS != 'None'License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.