Conversation
ghost
reviewed
Mar 8, 2022
ghost
reviewed
Mar 8, 2022
| if [[ "${checked_value}" == *"${resource_value}"* ]]; then | ||
| # To set WARNING flag checked_value have to include value of resource_value | ||
| # If it is treated as only expanse (*[]*) will not detect regex like [:alpha:] | ||
| if [[ "${checked_value}" =~ ${resource_value} ]]; then |
There was a problem hiding this comment.
This look good! Thanks for sorting it out :)
ghost
previously approved these changes
Mar 8, 2022
MrCloudSec
approved these changes
Mar 8, 2022
Contributor
MrCloudSec
left a comment
MrCloudSec
left a comment
There was a problem hiding this comment.
Thank you @wobblesprout
jfagoagas
approved these changes
Mar 11, 2022
jfagoagas
deleted the
PRWLR-238-whitelisting-doesnt-match-example-in-whitelist-sample-txt
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Current whitelisting logic did not detect whitelisted element if includes POSIX character classes
Description
Reformulate whitelisting logic to detect POSIX character classes into whitelisted element
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.