Skip to content

fix(extra776): Handle image tag commas and json output#1063

Merged
toniblyx merged 1 commit intomasterfrom
PRWLR-219-check-extra-776-doesnt-insert-the-information-properly
Mar 8, 2022
Merged

fix(extra776): Handle image tag commas and json output#1063
toniblyx merged 1 commit intomasterfrom
PRWLR-219-check-extra-776-doesnt-insert-the-information-properly

Conversation

@jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Mar 8, 2022

Context

We need to fix extra776 in order not to break csv output format.

Description

  • Handle ECR images with multiple tag separated by commas only recovering last occurrence with head -n 1
  • Use --output json when needed otherwise it fails if your default output is text
  • Included a more granular handling for authentication errors.
  • More comments

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas force-pushed the PRWLR-219-check-extra-776-doesnt-insert-the-information-properly branch from 0500559 to 66cf1c8 Compare March 8, 2022 17:54
@jfagoagas jfagoagas marked this pull request as ready for review March 8, 2022 17:55
@jfagoagas jfagoagas requested review from a team, MrCloudSec, n4ch04 and toniblyx March 8, 2022 17:55
Copy link
Member

@toniblyx toniblyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toniblyx toniblyx merged commit 0c1c641 into master Mar 8, 2022
@toniblyx toniblyx deleted the PRWLR-219-check-extra-776-doesnt-insert-the-information-properly branch March 8, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants