fix(filter-region): Support comma separated regions#1071
Merged
Conversation
thetemplateblog
requested review from
a team,
MrCloudSec,
jfagoagas and
toniblyx
toniblyx
requested changes
Mar 16, 2022
Co-authored-by: Toni de la Fuente <toni@blyx.com>
jfagoagas
reviewed
Mar 16, 2022
toniblyx
approved these changes
Mar 16, 2022
Member
|
Thank you @thetemplateblog, good catch!! 👏 |
jfagoagas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When filtering on regions, the results are not as expected. None of the workarounds from #887 worked in my case. I have found that if regions are comma delimited, the filter works as intended. The problem with using single quotes is that the single quotes are passed into $FILTERREGION and the aws command line won't work like that.
Description
Using a simple bash replace character on line 344 of the prowler bash script allows the -f value to be delimited using a comma.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.