Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore archived findings in GuardDuty for check extra7139 @chbiel #851

Merged

Conversation

chbiel
Copy link
Contributor

@chbiel chbiel commented Aug 19, 2021

As the check should only look at active findings, not those that were moved to the archive of guardduty.
It does not make sense to include the archived findings as this is the guardduty way of saying "I accept this finding".

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ndings, not those that were moved to the archive of guardduty
Copy link
Contributor

@w0rmr1d3r w0rmr1d3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's wait for @toniblyx and his approval

@toniblyx toniblyx changed the title Ignore archvived findings in guardduty (check_extra7139) Ignore archvived findings in GuardDuty for check extra7139 @chbiel Aug 25, 2021
@toniblyx toniblyx changed the base branch from master to 2.5.1 August 25, 2021 09:25
@toniblyx toniblyx changed the title Ignore archvived findings in GuardDuty for check extra7139 @chbiel Ignore archived findings in GuardDuty for check extra7139 @chbiel Aug 25, 2021
@toniblyx toniblyx merged commit a72a2e9 into prowler-cloud:2.5.1 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants