Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New check 7154 CloudFormation stack termination protection enabled @ShubhamShah11 #877

Merged
merged 11 commits into from Oct 5, 2021

Conversation

ShubhamShah11
Copy link
Contributor

Adding a check to verify if CloudFormation stacks have termination protection enabled.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toniblyx toniblyx changed the title Adding new check [ check_extra7154 ] New check 7154 CloudFormation stack termination protection enabled @ShubhamShah11 Sep 23, 2021
@toniblyx toniblyx changed the base branch from master to 2.5.1 September 23, 2021 08:18
checks/check_extra7154 Outdated Show resolved Hide resolved
Copy link
Contributor

@w0rmr1d3r w0rmr1d3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
@toniblyx the group7 is being deleted here, is that alright?

@toniblyx
Copy link
Member

extras group shouldn´t be deleted however considering that are a bunch of checks coming up, there are conflicts so I will update it later

@toniblyx toniblyx merged commit 53e5681 into prowler-cloud:2.5.1 Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants