Skip to content

New check 7162 CloudWatch log groups have 365 days retention @Obiakara - #935

Merged
toniblyx merged 3 commits into
prowler-cloud:2.7from
Obiakara:check_extra7162
Nov 23, 2021
Merged

New check 7162 CloudWatch log groups have 365 days retention @Obiakara#935
toniblyx merged 3 commits into
prowler-cloud:2.7from
Obiakara:check_extra7162

Conversation

@Obiakara

Copy link
Copy Markdown

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toniblyx toniblyx changed the title Added check_extra7162 which checks if Log groups have 365 days retention New check 7162 CloudWatch log groups have 365 days retention @Obiakara Nov 19, 2021
@toniblyx

Copy link
Copy Markdown
Member

Thanks @Obiakara, let me add some comments and change suggestions here:

  • For the title probably "Check if CloudWatch Log Groups have a retention policy of 365 days" sounds more comprehensive.
  • Resource type is: AwsLogsLogGroup
  • Service name is: cloudwatch (I know it is logs but we are consolidating this type of checks in cloudwatch so far).
  • Please, for future optional changes put 365 in a variable inside the function. Like LOG_GROUP_RETENTION_PERIOD_DAYS= in case somebody else needs to adapt it is will be easier. Then use that variable in the text messages as well.

Thanks!

@Obiakara

Copy link
Copy Markdown
Author

Thanks @toniblyx for your feedback. I made the changes and commited again

@toniblyx
toniblyx changed the base branch from master to 2.7 November 23, 2021 10:07
@toniblyx
toniblyx merged commit d45cab2 into prowler-cloud:2.7 Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants